Skip to content

[Backport] Fix #4803: Incorrect return value from Product Attribute Repository #15688

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
magento-engcom-team merged 3 commits into from
Aug 8, 2018
Merged

[Backport] Fix #4803: Incorrect return value from Product Attribute Repository #15688

magento-engcom-team merged 3 commits into from
Aug 8, 2018

Conversation

@julian-van-drielen
Copy link

@julian-van-drielen julian-van-drielen commented Jun 2, 2018 •
edited by ihor-sviziev
Loading

Description

@vkublytskyi Suggested this fix to resolve issue #4803,

Fixed Issues (if relevant)

  1. Incorrect return value from Product Attribute Repository #4803: Incorrect return value from Product Attribute Repository

Manual testing scenarios

  1. This can be tested by calling the function Magento\Catalog\Model\Product\Attribute\Repository::getCustomAttributesMetadata and check return type.

Contribution checklist

  • [✓] Pull request has a meaningful description of its purpose
  • [✓] All commits are accompanied by meaningful commit messages
  • [✓] All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

Added Magento\Framework\Api\MetadataObjectInterface to extends of Mag…
d409248 
…ento\Eav\Api\Data\AttributeInterface as suggested by vkublytskyi
@julian-van-drielen julian-van-drielen mentioned this pull request Jun 2, 2018
Merged
1 task
@julian-van-drielen julian-van-drielen mentioned this pull request Jun 3, 2018
Merged
1 task
@okorshenko okorshenko removed the mm18nl label Jun 5, 2018
@orlangur orlangur changed the title Return value fix on ProductAttributeRepository [Backport] Fix #4803: Incorrect return value from Product Attribute Repository Jul 11, 2018
@orlangur orlangur self-assigned this Jul 11, 2018
@magento-engcom-team magento-engcom-team added this to the Release: 2.1.16 milestone Aug 8, 2018
@sidolov sidolov mentioned this pull request Aug 8, 2018
Closed
@magento-engcom-team magento-engcom-team merged commit b064cd7 into magento:2.1-develop Aug 8, 2018
magento-engcom-team pushed a commit that referenced this pull request Aug 8, 2018
ENGCOM-2707: [Backport] Fix #4803: Incorrect return value from Produc…
8f77ca1 
…t Attribute Repository #15688
@magento-engcom-team
Copy link
Contributor

magento-engcom-team commented Aug 8, 2018

Hi @cream-julian. Thank you for your contribution.
We will aim to release these changes as part of 2.1.16.
Please check the release notes for final confirmation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@orlangur orlangur

@sidolov sidolov

Labels

Community Insider: Cream community-insider-contribution Component: Eav Progress: accept Release Line: 2.1

Projects

None yet

Milestone

Release: 2.1.16

Development

Successfully merging this pull request may close these issues.

7 participants

@julian-van-drielen @magento-engcom-team @orlangur @dverkade @okorshenko @sidolov @gelanivishal