Skip to content

[Backport] Fix unnecessary recalculation of product list pricing #15445

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 31, 2018
Merged

[Backport] Fix unnecessary recalculation of product list pricing #15445

merged 1 commit into from
May 31, 2018

Conversation

@Jeroenll
Copy link
Member

Original Pull Request

#15089

Description

Unnecessary recalculation of large product list pricing causes huge slowdowns.

Fixed Issues (if relevant)

  1. Unnecessary recalculation of product list pricing causes huge slowdowns #14941: Unnecessary recalculation of product list pricing causes huge slowdowns

Manual testing scenarios

  1. Create a catalog where prices are including tax + prices are shown including tax.
  2. Go to a category page and show 100 products per page.

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@Jeroenll Jeroenll added Release Line: 2.1 backport partners-contribution Pull Request is created by Magento Partner Partner: Reach Digital Pull Request is created by partner Reach Digital Partner: H&O labels May 23, 2018
@Jeroenll
Copy link
Member Author

@miguelbalparda Can you also do this backport?

@miguelbalparda miguelbalparda self-assigned this May 23, 2018
@miguelbalparda
Copy link
Contributor

Yes @JeroenVanLeusden, thanks for all the help!!

@magento-engcom-team magento-engcom-team added this to the Release: 2.1.15 milestone May 28, 2018
@magento-engcom-team
Copy link
Contributor

Hi @miguelbalparda, thank you for the review.
ENGCOM-1693 has been created to process this Pull Request

@ishakhsuvarov ishakhsuvarov mentioned this pull request May 31, 2018
Closed
@magento-engcom-team magento-engcom-team merged commit 3d05e6b into magento:2.1-develop May 31, 2018
magento-engcom-team pushed a commit that referenced this pull request May 31, 2018
ENGCOM-1693: [Backport] Fix unnecessary recalculation of product list…
d871eb8 
… pricing #15445
@magento-engcom-team
Copy link
Contributor

Hi @JeroenVanLeusden. Thank you for your contribution.
Changes from your Pull Request will be available with the upcoming 2.1.15 release.

@Jeroenll Jeroenll deleted the 2.1-develop-PR-port-15089 branch July 9, 2018 07:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@miguelbalparda miguelbalparda miguelbalparda approved these changes

Assignees

@miguelbalparda miguelbalparda

Labels

Component: Tax Partner: H&O Partner: Reach Digital Pull Request is created by partner Reach Digital partners-contribution Pull Request is created by Magento Partner Progress: accept Release Line: 2.1

Projects

None yet

Milestone

Release: 2.1.15

Development

Successfully merging this pull request may close these issues.

3 participants

@Jeroenll @miguelbalparda @magento-engcom-team