[Backport] Fix typo in database column comment #15290
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VitaliyBoyko
added
backport
partners-contribution
DanielRuf
approved these changes
May 17, 2018
|
Hi, @VitaliyBoyko, Your fix introduce changes in the DB schema. Due to Magento backward-compatible guide we can't make changes to DB schema in 2.1 Magento version. |
|
@vladimir-k also not with I also see no mention of schema name changes (or what is the last parameter?). |
|
@DanielRuf yes, you are right, the last parameter it's only comment. Our tests are failed on this fix, so I closed this PR, but in the current case I agree, we can merge it. |
magento-engcom-team
pushed a commit
that referenced
this pull request
Jun 7, 2018
|
Hi @VitaliyBoyko. Thank you for your contribution. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Original PR: #13318
Description
Fix typo in database column comment