Skip to content

#14918 improve Indexer Batch Provider #14919

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

#14918 improve Indexer Batch Provider #14919

wants to merge 2 commits into from

Conversation

thiagolima-bm
Copy link
Member

@thiagolima-bm thiagolima-bm commented Apr 30, 2018 •
edited
Loading

FIX: Ineficient Indexer Batch Provider #14918

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@magento-engcom-team magento-engcom-team added this to the April 2018 milestone Apr 30, 2018
@magento-engcom-team magento-engcom-team added Release Line: 2.3 Partner: Interactiv4 Pull Request is created by partner Interactiv4 partners-contribution Pull Request is created by Magento Partner labels Apr 30, 2018
@magento-engcom-team
Copy link
Contributor

@thiagolima-bm thank you for contributing. Please accept Community Contributors team invitation here to gain extended permissions for this repository.

@thiagolima-bm
Copy link
Member Author

Somehow travis is failing..

larsroettig
larsroettig reviewed May 2, 2018
View reviewed changes
Copy link
Member

@larsroettig larsroettig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @thiagolima-bm, I restart the build it was javascript test problem on Travis. The code looks for me good. I have not timed for manually testing.

Best regards,

Lars

@thiagolima-bm
Copy link
Member Author

Thanks @larsroettig ;)

@okorshenko okorshenko modified the milestones: April 2018, May 2018 May 18, 2018
@okorshenko okorshenko removed this from the May 2018 milestone May 31, 2018
@magento-engcom-team magento-engcom-team added this to the Release: 2.3.0 milestone Aug 16, 2018
@ghost ghost mentioned this pull request Nov 6, 2018
Closed
@sivaschenko sivaschenko self-assigned this Nov 19, 2018
@sivaschenko
Copy link
Member

Hi @thiagolima-bm , those changes are not backward compatible. Is there a way to introduce these as a separate interface/implementation (dropping the $linkField parameter and changing keys of generator).

@sidolov
Copy link
Contributor

sidolov commented Dec 4, 2018

Hi @thiagolima-bm , I am closing this PR now due to inactivity.
Please reopen and update if you wish to continue.
Thank you for the collaboration!

@sidolov sidolov closed this Dec 4, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@larsroettig larsroettig larsroettig left review comments

Assignees

@sivaschenko sivaschenko

@VladimirZaets VladimirZaets

@sidolov sidolov

Labels
Component: Framework/Indexer Partner: Interactiv4 Pull Request is created by partner Interactiv4 partners-contribution Pull Request is created by Magento Partner Progress: needs update Release Line: 2.3
Projects
None yet
Milestone
Release: 2.3.1
Development

Successfully merging this pull request may close these issues.
7 participants
@thiagolima-bm @magento-engcom-team @sivaschenko @sidolov @larsroettig @okorshenko @VladimirZaets