Skip to content

Conversation

@Jeroenll
Copy link
Member

@Jeroenll Jeroenll commented Apr 10, 2018

Description

When using GET /V1/orders/items/{id} the parent item isn't set. This PR will add the parent item if the parent_item_id is set.

Fixed Issues (if relevant)

  1. None

Manual testing scenarios

  1. Order a configurable product.
  2. Fetch the ordered simple product using GET /V1/orders/items/{id}.
  3. parent_item_id is set but parent_item isn't.

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@Jeroenll Jeroenll added partners-contribution Pull Request is created by Magento Partner Partner: Reach Digital Pull Request is created by partner Reach Digital labels Apr 10, 2018
@ihor-sviziev
Copy link
Contributor

Hi @JeroenVanLeusden,
Your changes looks good to me. Could you cover them with tests?

@Jeroenll
Copy link
Member Author

Jeroenll commented Apr 11, 2018

Sure, hopefully have some time by end of this week. Will ping you when ready.

Edit:
@ihor-sviziev Struggling to make up some good test cases any ideas to help me setting up?

@ihor-sviziev
Copy link
Contributor

@JeroenVanLeusden I think good option there will be adding new integration test that will check after getting parent item is present

@Jeroenll
Copy link
Member Author

Have time by end of the week to update the PR, just so you know ;)

@Jeroenll Jeroenll force-pushed the JeroenVanLeusden-patch-1 branch from a5f2b6c to f121e1c Compare May 8, 2018 16:32
@Jeroenll
Copy link
Member Author

Jeroenll commented May 8, 2018

@ihor-sviziev PR is updated with test.

@ihor-sviziev ihor-sviziev self-requested a review May 8, 2018 16:41
@magento-engcom-team
Copy link
Contributor

Hi @ihor-sviziev, thank you for the review.
ENGCOM-1531 has been created to process this Pull Request

@magento-engcom-team
Copy link
Contributor

Hi @JeroenVanLeusden. Thank you for your contribution.
Changes from your Pull Request will be available with the upcoming 2.2.5 release.

@Jeroenll Jeroenll deleted the JeroenVanLeusden-patch-1 branch May 17, 2018 13:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Partner: H&O Partner: Reach Digital Pull Request is created by partner Reach Digital partners-contribution Pull Request is created by Magento Partner Progress: accept Release Line: 2.2

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants