Skip to content

Conversation

@namlier
Copy link
Contributor

@namlier namlier commented Mar 20, 2018

Original Pull Request

#13956

Description

Refactored the implementation of the 'ajax:addToCart' trigger that was used in the ajaxSubmit function when adding a product to the cart. The code now leans more closely towards how Magento has already implemented this type of event triggering.

Also by passing an object in the trigger function instead of passing x number of variables, we allow for more generic solutions when trying to observe multiple triggers with a single function.

Fixed Issues (if relevant)

  1. Follow up on Add more parameters to ajax:addToCart #12875

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

… adding a product to the cart. The code now leans more closely to how this type of event triggering has already been implemented in Magento
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants