Skip to content

Conversation

AntonEvers
Copy link
Contributor

@AntonEvers AntonEvers commented Jan 11, 2018

…il, not the specific store email

Fixes #13120

Description

Backport of 9fc059b

Fixed Issues (if relevant)

  1. MDVA-275 code is not present in Magento 2.1-develop - 2.3-develop #13120: MDVA-275 code is not present in Magento 2.1-develop - 2.3-develop

Manual testing scenarios

  1. see MDVA-275 code is not present in Magento 2.1-develop - 2.3-develop #13120

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@orlangur orlangur self-assigned this Jan 11, 2018
@orlangur orlangur added this to the January 2018 milestone Jan 11, 2018
@AntonEvers AntonEvers force-pushed the backport-mdva-275-2.2 branch from e43cb3d to c716aec Compare January 14, 2018 04:35
@orlangur
Copy link
Contributor

Somehow the same tests are green on Travis CI and few of them are broken on Bamboo, need to find out why.

@sidolov
Copy link
Contributor

sidolov commented May 8, 2018

Hi @ajpevers , we found that new Transport builder that send the message according to scope was introduced in the pull request #11992, so, looks like we need just refactor all usages of old transport builder with new. In that case new method setScope no needed

@sidolov
Copy link
Contributor

sidolov commented May 27, 2018

@ajpevers , I am closing this PR now due to inactivity.
Please reopen and update if you wish to continue.
Thank you for collaboration!

@sidolov sidolov closed this May 27, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Partner: Kega partners-contribution Pull Request is created by Magento Partner Release Line: 2.2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants