-
Notifications
You must be signed in to change notification settings - Fork 9.4k
#12808 Add support for 'Skip errors' validation strategy #12867
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Hey @JustBeYou thank you for this Pull Request. I will review and process this now. If I need anything I will communicate that with you. |
* | ||
* @return string | ||
*/ | ||
public function getValidationStrategy(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unfortunately in this type of release (a PR to 2.2-develop is considered a Patch release) we cannot change interface classes because of our BiC guidelines. It would be a good idea to add a new interface and migrate any similar methods to this new interface (see http://devdocs.magento.com/guides/v2.2/contributor-guide/backward-compatible-development/index.html#introduction-of-a-method-to-a-class-or-interface for more information)
Hey @JustBeYou are you still interested in working on this Pull Request? If so could you have a look into the requested changes with regards to backwards compatibility. Thanks |
Hi @JustBeYou I am going to close this pull request due to inactivity. Thank you for your effort so far, if you would like to come back to this at a later date feel free to open a new pull request with the requested changes or reach out of one of the team to help out. Thank you. |
Description
I added in the validation phase of CVS importing some checks about validation strategy. Now, if the validation strategy is chosen to be 'Skip errors', the CVS file will be imported if the invalid rows number is smaller or equal to the number of allowed errors. In the previous versions, even if this option is selected, the data validation will fail if any invalid row is found.
Fixed Issues (if relevant)
Manual testing scenarios
Contribution checklist