Skip to content

Magento 2.2.2-dev - CSV Import, skip errors not working #12808

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
JustBeYou opened this issue Dec 19, 2017 · 9 comments
Closed

Magento 2.2.2-dev - CSV Import, skip errors not working #12808

JustBeYou opened this issue Dec 19, 2017 · 9 comments
Labels
Component: ImportExport Issue: Clear Description Gate 2 Passed. Manual verification of the issue description passed Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development Reproduced on 2.1.x The issue has been reproduced on latest 2.1 release Reproduced on 2.2.x The issue has been reproduced on latest 2.2 release Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release

Comments

@JustBeYou
Copy link

Preconditions

  1. Magento version is 2.2.2 as specified in the title and I think is the only relevant info about the environment
  2. PHP 7.0.25
  3. MySQL Ver 15.1 Distrib 10.1.29-MariaDB
  4. Cent OS 7 (Linux 3.10.0-693.11.1.el7.x86_64 # 1 SMP Mon Dec 4 23:52:40 UTC 2017 x86_64 GNU/Linux)

Steps to reproduce

  1. Go to System > Data Transfer > Import
  2. Select 'Products' for 'Entity type'
  3. Select 'Add/Update' behavior and 'Skip error entries' for strategy
  4. Select some arbitrary number for 'Allowed Errors Count' bigger than your actual error count from CSV file
  5. Select a CSV file to import with few errors, but not more than the number specified in 'Allowed Errors Count'
  6. Check the data

Expected result

  1. Should let me import the CSV file ignoring the errors

Actual result

  1. The checking data phase just fail and I can't continue to the actual import
    screenshot_20171219_155548
    screenshot_20171219_155627

I did some research on this problem and I've found that it was reported somehow in earlier versions (2.1.x), but the issues I've found on this bug didn't come to some solution. The first I've found is #5831, but it is closed because it's marked as a duplicate of this #5334, but this is closed too as it is not clear enough.

I want to know if is this is fixed in any 2.2.x > 2.2.2 version (just supposing, I think 2.2.2 is the last release) or if is anyone already working on it? If no one is working I could try to fix it as I am already looking at Magento/ImportExport/Model/Import because I think the problem is here, but I don't want to waste my time if there is already fixed in another version.

Have a nice day!

@magento-engcom-team magento-engcom-team added the Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed label Dec 19, 2017
@PieterCappelle
Copy link
Contributor

PieterCappelle commented Dec 21, 2017

Issue is not fixed in 2.2-develop and 2.3-develop. So yes, its an issue. Will you fix this with PR?

@JustBeYou
Copy link
Author

OK then. I am going to make a fork and try to get a fix. I will create a pull request when I'm done.

@PieterCappelle
Copy link
Contributor

Let me know if I can help you @JustBeYou :)

@magento-engcom-team magento-engcom-team added the Issue: Clear Description Gate 2 Passed. Manual verification of the issue description passed label Dec 22, 2017
@magento-engcom-team
Copy link
Contributor

@JustBeYou, thank you for your report.
We've created internal ticket(s) MAGETWO-85966 to track progress on the issue.

@magento-engcom-team magento-engcom-team added Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Reproduced on 2.1.x The issue has been reproduced on latest 2.1 release Reproduced on 2.2.x The issue has been reproduced on latest 2.2 release Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release labels Dec 22, 2017
@JustBeYou
Copy link
Author

Fixed in #12867. I am waiting for a review.

@PieterCappelle
Copy link
Contributor

PieterCappelle commented Dec 23, 2017

Nice @JustBeYou! If accepted please create backport to 2.2 too :-) #thanks!

@JustBeYou
Copy link
Author

@PieterCappelle I developed the bug-fix on 2.2. Should I create a pull request for 2.1 and 2.3 too?

@PieterCappelle
Copy link
Contributor

Sorry. Yes, if accepted, please create backport for 2.1 & 2.3. Currently we are setting up a team from developers to fix issues and refactor the current import of Magento2. You can always join our channel on slack #import-export. We also have custom repository > https://github.com/magento-engcom/import-export-improvements/projects

Have a nice day today! 24th :)

@piotrekkaminski
Copy link
Contributor

This issue was moved to magento-engcom/import-export-improvements#75

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: ImportExport Issue: Clear Description Gate 2 Passed. Manual verification of the issue description passed Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development Reproduced on 2.1.x The issue has been reproduced on latest 2.1 release Reproduced on 2.2.x The issue has been reproduced on latest 2.2 release Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release
Projects
None yet
Development

No branches or pull requests

5 participants