Skip to content

magento/magento2#5035 Cannot subscribe to events with a number in name #12758

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
magento-team merged 2 commits into from
Dec 22, 2017
Merged

magento/magento2#5035 Cannot subscribe to events with a number in name #12758

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
937b26d
magento/magento2#5035
Mobecls Dec 15, 2017
85fa671
magento/magento2#5035
Mobecls Dec 15, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions lib/internal/Magento/Framework/Event/Test/Unit/Config/_files/valid_events.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,4 +12,7 @@
<event name="authorization_roles_save_before">
<observer name="second_name" instance="Some_Test_Value_Two" />
</event>
<event name="authorization_roles_save_before123">
<observer name="second_name" instance="Some_Test_Value_Two" />
</event>
</config>
4 changes: 2 additions & 2 deletions lib/internal/Magento/Framework/Event/etc/events.xsd
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,11 +60,11 @@
<xs:simpleType name="eventName">
<xs:annotation>
<xs:documentation>
Event name can contain only [a-zA-Z_].
Event name can contain only [a-zA-Z0-9_].
</xs:documentation>
</xs:annotation>
<xs:restriction base="xs:string">
<xs:pattern value="[a-zA-Z_]+" />
<xs:pattern value="[a-zA-Z0-9_]+" />
</xs:restriction>
</xs:simpleType>
</xs:schema>