Skip to content

Conversation

@zamoroka
Copy link
Member

@zamoroka zamoroka commented Dec 15, 2017

Description

  • Fixed regexp pattern for range-words validation
  • Added tests

Fixed Issues (if relevant)

  1. Validate range-words in Form component (UI Component) #6113: Validate range-words in Form component (UI Component)

Manual testing scenarios

  1. Edit /app/code/Magento/Catalog/view/adminhtml/ui_component/new_category_form.xml:
    In node with '<field name="name"' replace
    <rule name="required-entry" xsi:type="boolean">true</item>
    to
    <rule name="range-words" xsi:type="array">
    <item name="0" xsi:type="number">1</item>
    <item name="1" xsi:type="number">3</item>
    </rule>
  2. Flush cache.
  3. In Admin, open any product and click "New Category"
  4. Enter any value in "Category Name" field, set any "Parent Category" and press "Create Category"

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

- Fixed regexp pattern for range-words validation
@magento-engcom-team magento-engcom-team added bugfix mageconf Reproduced on 2.1.x The issue has been reproduced on latest 2.1 release Reproduced on 2.2.x The issue has been reproduced on latest 2.2 release Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release labels Dec 15, 2017
@ishakhsuvarov ishakhsuvarov self-assigned this Dec 18, 2017
@ishakhsuvarov ishakhsuvarov added this to the December 2017 milestone Dec 18, 2017
@magento-team magento-team merged commit e9dcb03 into magento:2.2-develop Dec 22, 2017
@magento-engcom-team magento-engcom-team added the Fixed in 2.2.x The issue has been fixed in 2.2 release line label Dec 22, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bugfix Fixed in 2.2.x The issue has been fixed in 2.2 release line Progress: accept Release Line: 2.2 Reproduced on 2.1.x The issue has been reproduced on latest 2.1 release Reproduced on 2.2.x The issue has been reproduced on latest 2.2 release Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants