#12625: Add Current Date to update_time Field for Block and Pages

[osrecio]

Set Current Date Time to update_time field

Description

add current date time to 'update_time' in _beforeSave method for Page and Block

Fixed Issues (if relevant)

1. when saving a page in magento 2.2.1, 'Modified' date field is not getting updated #12625: when saving a page in magento 2.2.1, 'Modified' date field is not getting updated

Manual testing scenarios

1. Login to magento admin
2. Go to Content > Pages
3. In Action column, click select > edit
4. Make changes to that page and click 'Save Page'

Contribution checklist

• Pull request has a meaningful description of its purpose
• All commits are accompanied by meaningful commit messages
• All new or changed code is covered with unit/integration tests (if applicable)
• All automated tests passed successfully (all builds on Travis CI are green)

[mzeis]

Hi @osrecio,

thanks for your pull request! Please can you have a look at the failing integration test?

[osrecio]

@mzeis Adapted Tests

[sidolov]

Please, use framework implementation for date value \Magento\Framework\Stdlib\DateTime\DateTime::date

[osrecio]

@sidolov Changes made, and added integration tests for Cms Block 😃

[mzeis]

It's better to get the object manager in the setUp method (example).

[osrecio]

@mzeis Added ObjectManager to setUp.

I copied test from dev/tests/integration/testsuite/Magento/Cms/Model/PageTest.php

[osrecio]

@sidolov I followed your suggestions and I adapted my PR.

[mzeis]

@osrecio When comparing the changes with #12625, I noticed that the implementation changes are the same but the tests are carried out differently. Would it make sense to adjust the integration tests here to make them equal to 2.3-develop?

[osrecio]

@mzeis Are you referring to the tests changed in branch 2.3-develop of my other PR?

These test: BlockTest.php , PageTest.php

Thanks!

[mzeis]

@osrecio Yes exactly. Since Stanislav approved your changes in #12637 I thought it might be a good idea to keep the code between 2.2 and 2.3 as similar as possible.

[osrecio]

I will work to make these changes, Thanks @mzeis

[osrecio]

Hi @mzeis I adapted BlockTest.php like 2.3-develop in PageTest.php nothing to do because other methods in tests covering new funcionality not included in 2.2-develop.

[sidolov]

@osrecio, please, check failed static tests

[osrecio]

@sidolov Fixed Static Tests, the pre-commit deleted by me the reference in namespace 😄

[mzeis]

@osrecio Many thanks for your contribution. It has been merged. Happy holidays! 🎄

[osrecio]

Thanks @mzeis , Happy holidays and happy new year!!