Skip to content

9768: Admin dashboard Most Viewed Products Tab only gives default attribute set's products (backport for 2.1) #12137

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 1, 2017

Conversation

RomaKis
Copy link
Contributor

@RomaKis RomaKis commented Nov 9, 2017

Admin dashboard Most Viewed Products Tab only gives default attribute set's products. Backport from #11725.

Fixed Issues (if relevant)

  1. Admin dashboard Most Viewed Products Tab only gives default attribute set's products #9768: Admin dashboard Most Viewed Products Tab only gives default attribute set's products

Manual testing scenarios

  1. Login to Customer Account
  2. Visited Product "Minerva LumaTech™ V-Tee"
  3. Login to magento admin panel
  4. Check magento dashboard "Most Viewed Product" grid

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@magento-engcom-team magento-engcom-team added Admin Panel bugfix Reproduced on 2.1.x The issue has been reproduced on latest 2.1 release Reproduced on 2.2.x The issue has been reproduced on latest 2.2 release Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release labels Nov 9, 2017
@miguelbalparda miguelbalparda self-assigned this Nov 9, 2017
@miguelbalparda miguelbalparda added this to the November 2017 milestone Nov 9, 2017
Copy link
Contributor

@miguelbalparda miguelbalparda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems to differ from the other 2 PRs for this fix. Can you double check it please?

@RomaKis
Copy link
Contributor Author

RomaKis commented Nov 9, 2017

@miguelbalparda, changes are different only in unit test, bacause 2.1.x use \PHPUnit_Framework_TestCase class instead of \PHPUnit\Framework\TestCase in 2.2.

@magento-engcom-team magento-engcom-team added the Fixed in 2.2.x The issue has been fixed in 2.2 release line label Nov 26, 2017
@miguelbalparda
Copy link
Contributor

@dmanners can you check this one? All the other backports are already merged, I suspect this one hasn't been picked up yet because of the request for changes but now should be good to go.

@okorshenko okorshenko merged commit ef6a9a4 into magento:2.1-develop Dec 1, 2017
okorshenko pushed a commit that referenced this pull request Dec 1, 2017
…ves default attribute set's products (backport for 2.1) #12137
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix Fixed in 2.2.x The issue has been fixed in 2.2 release line Progress: accept Release Line: 2.1 Reproduced on 2.1.x The issue has been reproduced on latest 2.1 release Reproduced on 2.2.x The issue has been reproduced on latest 2.2 release Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants