Skip to content

Fix for url_rewrite on page delete via api #10568

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 18, 2017
Merged

Fix for url_rewrite on page delete via api #10568

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
31a45ca
Fix for url_rewrite on page delete via api
Aug 17, 2017
2ae95d1
magento/magento2#10568: Fix for url_rewrite on page delete via api
ishakhsuvarov Aug 17, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
0 ...agento/CmsUrlRewrite/etc/adminhtml/di.xml → app/code/Magento/CmsUrlRewrite/etc/di.xml
View file
Open in desktop
File renamed without changes.
63 changes: 63 additions & 0 deletions dev/tests/api-functional/testsuite/Magento/Cms/Api/PageRepositoryTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -284,6 +284,18 @@ public function testSearch()
);
}

/**
* Create page with the same identifier after one was removed.
*/
public function testCreateSamePage()
{
$pageIdentifier = 'page-' . uniqid();

$pageId = $this->createPageWithIdentifier($pageIdentifier);
$this->deletePageByIdentifier($pageId);
$this->createPageWithIdentifier($pageIdentifier);
}

/**
* @return PageInterface[]
*/
Expand Down Expand Up @@ -316,4 +328,55 @@ private function prepareCmsPages()

return $result;
}

/**
* Create page with hard-coded identifier to test with create-delete-create flow.
* @param string $identifier
* @return string
*/
private function createPageWithIdentifier($identifier)
{
$serviceInfo = [
'rest' => [
'resourcePath' => self::RESOURCE_PATH,
'httpMethod' => \Magento\Framework\Webapi\Rest\Request::HTTP_METHOD_POST,
],
'soap' => [
'service' => self::SERVICE_NAME,
'serviceVersion' => self::SERVICE_VERSION,
'operation' => self::SERVICE_NAME . 'Save',
],
];
$requestData = ['page' =>
[
PageInterface::IDENTIFIER => $identifier,
PageInterface::TITLE => 'Page title',
],
];

$result = $this->_webApiCall($serviceInfo, $requestData);
return $result['id'];
}

/**
* Remove page with hard-coded-identifier
* @param string $pageId
* @return void
*/
private function deletePageByIdentifier($pageId)
{
$serviceInfo = [
'rest' => [
'resourcePath' => self::RESOURCE_PATH . '/' . $pageId,
'httpMethod' => \Magento\Framework\Webapi\Rest\Request::HTTP_METHOD_DELETE,
],
'soap' => [
'service' => self::SERVICE_NAME,
'serviceVersion' => self::SERVICE_VERSION,
'operation' => self::SERVICE_NAME . 'DeleteById',
],
];

$this->_webApiCall($serviceInfo, [PageInterface::PAGE_ID => $pageId]);
}
}