-
Notifications
You must be signed in to change notification settings - Fork 9.4k
Closed
Labels
Fixed in 2.3.xThe issue has been fixed in 2.3 release lineThe issue has been fixed in 2.3 release lineIssue: Format is not validGate 1 Failed. Automatic verification of issue format is failedGate 1 Failed. Automatic verification of issue format is failedbug report
Description
In the file /app/code/Magento/Review/view/frontend/templates/review.phtml
there is a js function called processReviews
that (from what I understood) makes the pager use ajax.
but there is a problem with the <a>
tag selector for the paging.
Right now the selector looks like this: $('.pages a')
on line
$('.pages a').each(function(index, element) {
This works with a default install, but if I add other <a>
elements anywhere in the page that match this selector, clicking on them will trigger an ajax request. This is may not be the desired effect.
I think that the DOM selector should be $('#product-review-container .pages a')
to limit the selected elements to the reviews paging.
PS: I know I can do a pull request, but I prefer to let you fix this in case I'm wrong.
Metadata
Metadata
Assignees
Labels
Fixed in 2.3.xThe issue has been fixed in 2.3 release lineThe issue has been fixed in 2.3 release lineIssue: Format is not validGate 1 Failed. Automatic verification of issue format is failedGate 1 Failed. Automatic verification of issue format is failedbug report