Clicking on save twice while editing a configurable product causes current variations to disappear

[samgranger]

Preconditions

1. Magento2
2. Chrome

Steps to reproduce

1. Edit a configurable product and click on save.
2. Be impatient and click on save again a few times, just really go at it.
3. The 'current variations' are gone.

Expected result

1. Current variations shouldn't disappear

Actual result

1. Current variations are no longer current.

[fowbi]

We see the same behaviour in 2 of our installations, both running 2.1.1.

[fowbi]

The issue is caused when passing the configurable matrix for a second (or nth-time) to the controller via Ajax. The saveFormHandler in variations.js (in the ConfigurableProduct module) serialises the configurable-matrix value to configurable-matrix-serialized, but deletes the original configurable-matrix value afterwards. When the save button is pressed a second time, the configurable-matrix value will be empty and no simple products will be linked via the controller action.

Issue can be solved by editing the saveFormHandler in variations.js (https://github.com/magento/magento2/blob/develop/app/code/Magento/ConfigurableProduct/view/adminhtml/web/js/variations/variations.js#L306)

          saveFormHandler: function() {
              this.source.data["product"]["configurable-matrix-serialized"] =
                  JSON.stringify(this.source.data["configurable-matrix"]);
~             //delete this.source.data["configurable-matrix"];

[samgranger]

Thanks for the additional information fowbi, hopefully Magento will sort this issue out with your fix.

[yaroslavGoncharuk]

@samgranger, thanks for reporting this issue.
We've created internal ticket MAGETWO-61608 to address this issue.

[Isaiaham]

@fowbi @samgranger

For some reason, I cannot find the variations.js file under the file structure you reference above. I can go as far as html/app however, the /code folder does not exist. Where can I properly find this file in order to fix this annoying bug?