Shipment Create via API salesShipmentRepositoryV1 throw Fatal error in Admin Order -> Shipment -> View

[milindsingh]

Shipment Create via API salesShipmentRepositoryV1 throw Fatal error in Admin Order -> Shipment -> View

Preconditions (*)

1. Magento 2.3.1/2.3.0
2. The order created via Admin Panel

Steps to reproduce (*)

1. Create an order created from Admin Panel
2. Create Shipment via API:

{
  "entity": {
    "increment_id": "000000003",
    "order_id": 3,
    "items": [
        {
          "sku": "WSH12-32-Red",
          "qty": 1
        }
      ],
    "tracks": [
      {
        "order_id": 3,
        "qty": 1,
        "track_number": "123",
        "title": "Test",
        "carrier_code": "dhl"
      }
    ]  
  }
}

3. Goto Admin -> Sales -> Order -> View -> Shipments -> View

Expected result (*)

1. Shipment Details should be rendered without any Fatal Error as API shipment creation was successful.

Actual result (*)

1. Fatal Error in Admin Shipment View

Fatal error: Uncaught Error: Call to a member function getParentItem() on null in /opt/lampp7.2/htdocs/magento/2.3.sample/vendor/magento/module-shipping/view/adminhtml/templates/view/items.phtml:19 Stack trace: #0 /opt/lampp7.2/htdocs/magento/2.3.sample/vendor/magento/framework/View/TemplateEngine/Php.php(59): include() #1 /opt/lampp7.2/htdocs/magento/2.3.sample/vendor/magento/framework/View/Element/Template.php(271): Magento\Framework\View\TemplateEngine\Php->render(Object(Magento\Shipping\Block\Adminhtml\View\Items), '/opt/lampp7.2/h...', Array) #2 /opt/lampp7.2/htdocs/magento/2.3.sample/vendor/magento/framework/View/Element/Template.php(301): Magento\Framework\View\Element\Template->fetchView('/opt/lampp7.2/h...') #3 /opt/lampp7.2/htdocs/magento/2.3.sample/vendor/magento/module-backend/Block/Template.php(129): Magento\Framework\View\Element\Template->_toHtml() #4 /opt/lampp7.2/htdocs/magento/2.3.sample/vendor/magento/framework/View/Element/AbstractBlock.php(668): Magento\Backend\Block\Template->_toHtml() #5 /opt/lampp7 in /opt/lampp7.2/htdocs/magento/2.3.sample/vendor/magento/module-shipping/view/adminhtml/templates/view/items.phtml on line 19

Related Issues:
https://github.com/magento-engcom/msi/issues/2220
#17828

Note:
I think the Shipment creation via API have missed some required data, which is not validated at time of processing the call, causing fatal errors.

[m2-assistant]

Hi @milindsingh. Thank you for your report.
To help us process this issue please make sure that you provided the following information:

• Summary of the issue
• Information on your environment
• Steps to reproduce
• Expected and actual results

Please make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, please, add a comment to the issue:

@magento-engcom-team give me 2.3-develop instance - upcoming 2.3.x release

For more details, please, review the Magento Contributor Assistant documentation.

@milindsingh do you confirm that you was able to reproduce the issue on vanilla Magento instance following steps to reproduce?

• yes
• no

[m2-assistant]

Hi @milindsingh. Thank you for working on this issue.
In order to make sure that issue has enough information and ready for development, please read and check the following instruction: 👇

• 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).

  Details

  If the issue has a valid description, the label Issue: Format is valid will be added to the issue automatically. Please, edit issue description if needed, until label Issue: Format is valid appears.

• 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue. If the report is valid, add Issue: Clear Description label to the issue by yourself.

• 3. Add Component: XXXXX label(s) to the ticket, indicating the components it may be related to.

• 4. Verify that the issue is reproducible on 2.3-develop branch

  Details

  - Add the comment @magento-engcom-team give me 2.3-develop instance to deploy test instance on Magento infrastructure.
  - If the issue is reproducible on 2.3-develop branch, please, add the label Reproduced on 2.3.x.
  - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!

• 5. Verify that the issue is reproducible on 2.2-develop branch.
  Details

  - Add the comment @magento-engcom-team give me 2.2-develop instance to deploy test instance on Magento infrastructure.
  - If the issue is reproducible on 2.2-develop branch, please add the label Reproduced on 2.2.x

[m2-assistant]

Hi @shikhamis11. Thank you for working on this issue.
In order to make sure that issue has enough information and ready for development, please read and check the following instruction: 👇

• 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).

  Details

  If the issue has a valid description, the label Issue: Format is valid will be added to the issue automatically. Please, edit issue description if needed, until label Issue: Format is valid appears.

• 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue. If the report is valid, add Issue: Clear Description label to the issue by yourself.

• 3. Add Component: XXXXX label(s) to the ticket, indicating the components it may be related to.

• 4. Verify that the issue is reproducible on 2.3-develop branch

  Details

  - Add the comment @magento-engcom-team give me 2.3-develop instance to deploy test instance on Magento infrastructure.
  - If the issue is reproducible on 2.3-develop branch, please, add the label Reproduced on 2.3.x.
  - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!

• 5. Verify that the issue is reproducible on 2.2-develop branch.

  Details

  - Add the comment @magento-engcom-team give me 2.2-develop instance to deploy test instance on Magento infrastructure.
  - If the issue is reproducible on 2.2-develop branch, please add the label Reproduced on 2.2.x

• 6. Add label Issue: Confirmed once verification is complete.

• 7. Make sure that automatic system confirms that report has been added to the backlog.

[milindsingh]

#dmcdindia1

[m2-assistant]

Hi @engcom-backlog-nazar. Thank you for working on this issue.
In order to make sure that issue has enough information and ready for development, please read and check the following instruction: 👇

• 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).

  Details

  If the issue has a valid description, the label Issue: Format is valid will be added to the issue automatically. Please, edit issue description if needed, until label Issue: Format is valid appears.

• 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue. If the report is valid, add Issue: Clear Description label to the issue by yourself.

• 3. Add Component: XXXXX label(s) to the ticket, indicating the components it may be related to.

• 4. Verify that the issue is reproducible on 2.3-develop branch

  Details

  - Add the comment @magento-engcom-team give me 2.3-develop instance to deploy test instance on Magento infrastructure.
  - If the issue is reproducible on 2.3-develop branch, please, add the label Reproduced on 2.3.x.
  - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!

• 5. Verify that the issue is reproducible on 2.2-develop branch.

  Details

  - Add the comment @magento-engcom-team give me 2.2-develop instance to deploy test instance on Magento infrastructure.
  - If the issue is reproducible on 2.2-develop branch, please add the label Reproduced on 2.2.x

• 6. Add label Issue: Confirmed once verification is complete.

• 7. Make sure that automatic system confirms that report has been added to the backlog.

[milindsingh]

@engcom-backlog-nazar @orlangur @hostep

Magento Admin Shipment form does not allow the shipment to be created without Items or Zero qty items,
But the same can be done via API, causing an error in Admin.

Should we validate shipment create via API? (As I am already working on it, I need to know if it's done intentionally )

Thanks :)

[magento-engcom-team]

Hi @milindsingh. Thank you for your report.
The issue has been fixed in #22687 by @milindsingh in 2.3-develop branch
Related commit(s):

• 2e344f1f8bf26571bc0d41e65b4a34c6d46273fc

The fix will be available with the upcoming 2.3.3 release.