-
Notifications
You must be signed in to change notification settings - Fork 9.4k
Closed
Labels
Component: Framework/TranslateUSE ONLY for FRAMEWORK RELATED BUG! E.g If bug related to translation in Catalog use just CatalogUSE ONLY for FRAMEWORK RELATED BUG! E.g If bug related to translation in Catalog use just CatalogComponent: TranslationFixed in 2.2.xThe issue has been fixed in 2.2 release lineThe issue has been fixed in 2.2 release lineFixed in 2.3.xThe issue has been fixed in 2.3 release lineThe issue has been fixed in 2.3 release lineIssue: Clear DescriptionGate 2 Passed. Manual verification of the issue description passedGate 2 Passed. Manual verification of the issue description passedIssue: ConfirmedGate 3 Passed. Manual verification of the issue completed. Issue is confirmedGate 3 Passed. Manual verification of the issue completed. Issue is confirmedIssue: Format is validGate 1 Passed. Automatic verification of issue format passedGate 1 Passed. Automatic verification of issue format passedIssue: Ready for WorkGate 4. Acknowledged. Issue is added to backlog and ready for developmentGate 4. Acknowledged. Issue is added to backlog and ready for developmentReproduced on 2.3.xThe issue has been reproduced on latest 2.3 releaseThe issue has been reproduced on latest 2.3 release
Description
Preconditions
- Magento 2.3.0 Open Source
- At least one product available in store
- A translation file for the luma theme and storefront locale containing the phrase
"Cancel","Test"
- Static Content is deployed for the right locale and the translation cache is cleaned
Steps to reproduce
- Add an item to product compare list
- Go to product compare page
- Click on the remove item icon
Expected result
- A modal pops up asking to confirm the removal
- The left button of this modal should have the text "Test" on it
Actual result
- The text of the left modal button is "Cancel"
Additional information
The very first item in my js-translation.json is "Cancel":"Test"
, so this is not the issue.
When mage/translate.js
is called from modal/confirm.js
the _data[]
array is empty:
During the same page load, it will be loaded containing all phrases from the js-translation.json including the right phrase:
Metadata
Metadata
Assignees
Labels
Component: Framework/TranslateUSE ONLY for FRAMEWORK RELATED BUG! E.g If bug related to translation in Catalog use just CatalogUSE ONLY for FRAMEWORK RELATED BUG! E.g If bug related to translation in Catalog use just CatalogComponent: TranslationFixed in 2.2.xThe issue has been fixed in 2.2 release lineThe issue has been fixed in 2.2 release lineFixed in 2.3.xThe issue has been fixed in 2.3 release lineThe issue has been fixed in 2.3 release lineIssue: Clear DescriptionGate 2 Passed. Manual verification of the issue description passedGate 2 Passed. Manual verification of the issue description passedIssue: ConfirmedGate 3 Passed. Manual verification of the issue completed. Issue is confirmedGate 3 Passed. Manual verification of the issue completed. Issue is confirmedIssue: Format is validGate 1 Passed. Automatic verification of issue format passedGate 1 Passed. Automatic verification of issue format passedIssue: Ready for WorkGate 4. Acknowledged. Issue is added to backlog and ready for developmentGate 4. Acknowledged. Issue is added to backlog and ready for developmentReproduced on 2.3.xThe issue has been reproduced on latest 2.3 releaseThe issue has been reproduced on latest 2.3 release