Decrease dependencies from Mage class

[stalniy]

Why do you use Mage::helper instead Mage_Core_Block_Abstract::helper (e.g. the same file at line 191)? Using the last one choice you will get more flexibility.
Also it will be nice if you create a getConfigValue method instead of using Mage::getStoreConfig.

Then, in future, when you want to implement dependency injection pattern it will easier.

[magento-team]

Hi @stalniy,

Mage_Core_Block_Abstract::helper($name) calls $this->getLayout()->helper($name), which refers to the same Mage::helper($name).

Actually Mage::getStoreConfig() returns store config value.

[stalniy]

Hi. Yes i know this. But if you use Mage_Core_Block_Abstract::helper everywhere (where it's possible) instead of Mage::helper then in future it will be easy to improve architecture. Because you will need to change only one method in Mage_Core_Block_Abstract class and only in one file.

[magento-team]

You are right. It's easier if Mage_Core_Block_Abstract::helper() method should do something different from Mage::helper(). Thank you for the advise, we'll consider it, if Mage_Core_Block_Abstract class will be refactored.