Skip to content

Mqe 2215: Docs Annual Review Part 2 #760

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jul 20, 2020
Merged

Mqe 2215: Docs Annual Review Part 2 #760

merged 3 commits into from
Jul 20, 2020

Conversation

jilu1
Copy link
Contributor

@jilu1 jilu1 commented Jul 15, 2020

Description

Fixed Issues (if relevant)

  1. magento/magento2-functional-testing-framework#<issue_number>: Issue title
  2. ...

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/verification tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)
  • Changes to Framework doesn't have backward incompatible changes for tests or have related Pull Request with fixes to tests

@jilu1 jilu1 changed the base branch from develop to master July 15, 2020 21:48
dobooth
dobooth previously approved these changes Jul 16, 2020
View reviewed changes
soumyau
soumyau suggested changes Jul 17, 2020
View reviewed changes
Copy link
Contributor

@soumyau soumyau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor comment added. Need to update base branch to annual-docs.

@tomreece tomreece changed the base branch from master to annual-docs July 17, 2020 18:09
@coveralls
Copy link

coveralls commented Jul 17, 2020 •
edited
Loading

Coverage Status

Coverage remained the same at 55.85% when pulling 65a8ea3 on MQE-2215 into c275806 on annual-docs.

@jilu1 jilu1 changed the base branch from annual-docs to master July 17, 2020 21:27
@jilu1 jilu1 dismissed dobooth’s stale review July 17, 2020 21:27

The base branch was changed.

@jilu1 jilu1 changed the base branch from master to annual-docs July 17, 2020 21:28
@soumyau soumyau merged commit 8e42fda into annual-docs Jul 20, 2020
@soumyau soumyau added the DOC label Jul 22, 2020
@tomreece tomreece deleted the MQE-2215 branch July 27, 2020 14:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@soumyau soumyau soumyau requested changes

@dobooth dobooth dobooth left review comments

Assignees
No one assigned
Labels
DOC
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jilu1 @coveralls @soumyau @dobooth