Skip to content

MQE-1861: Suite precondition failure when using <createData> with <re… #744

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 24, 2020
Merged

MQE-1861: Suite precondition failure when using <createData> with <re… #744

merged 2 commits into from
Jun 24, 2020

Conversation

soumyau
Copy link
Contributor

@soumyau soumyau commented Jun 22, 2020

…quiredEntity>

Description

Fixed Issues (if relevant)

  1. magento/magento2-functional-testing-framework#<issue_number>: Issue title
  2. ...

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/verification tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)
  • Changes to Framework doesn't have backward incompatible changes for tests or have related Pull Request with fixes to tests

@coveralls
Copy link

coveralls commented Jun 22, 2020 •
edited
Loading

Coverage Status

Coverage increased (+0.2%) to 56.031% when pulling 2d4a046 on MQE-1861 into edb5c49 on develop.

jilu1
jilu1 reviewed Jun 24, 2020
View reviewed changes
dev/tests/verification/TestModule/Suite/functionalSuiteHooks.xml
<field key="someKey">dataHere</field>
</createData>
<click stepKey="clickWithData" userInput="$create.data$"/>
<createData entity="createEntityTwo" stepKey="createTwo">
<requiredEntity createDataKey="createEntityOne"/>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we add two requiredEntities in the verification test?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done.

jilu1
jilu1 approved these changes Jun 24, 2020
View reviewed changes
Copy link
Contributor

@jilu1 jilu1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@soumyau soumyau merged commit c0255ee into develop Jun 24, 2020
soumyau added a commit that referenced this pull request Jul 15, 2020
@soumyau
MQE-1861: Suite precondition failure when using <createData> with <re… (
ef134f2 
#744)

* MQE-1861: Suite precondition failure when using <createData> with <requiredEntity>

* MQE-1861: Suite precondition failure when using <createData> with <requiredEntity>
Added verification test
@tomreece tomreece deleted the MQE-1861 branch July 27, 2020 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jilu1 jilu1 jilu1 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@soumyau @coveralls @jilu1