Add version table and update instructions. #350
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dshevtsov
reviewed
May 10, 2019
docs/versioning.md
Outdated
| | 2.2.8 | 2.3.13 | | ||
| | 2.2.7 | 2.3.8 | | ||
|
|
||
| ## Updating MFTF |
There was a problem hiding this comment.
There is a topic about MFTF update: https://devdocs.magento.com/mftf/docs/update.html
Shouldn't it go there?
By the way, the topic uses composer update to update dependencies. (This should be reviewed I believe because this command updates all Magento dependencies, not only MFTF).
dshevtsov
reviewed
May 10, 2019
docs/versioning.md
Outdated
| @@ -56,3 +55,15 @@ It MAY include patch level changes. Patch version MUST be reset to 0 when minor | |||
| Major version **X** MUST be incremented for a release that introduces backward incompatible changes. | |||
| A major release can also include minor and patch level changes. | |||
| You must reset the patch and minor version to 0 when you change the major version. | |||
|
|
|||
| ## MFTF version table | |||
There was a problem hiding this comment.
The section title doesn't describe its substance. The topic itself is about MFTF versioning and we see that it contains a table. The heading should give an idea of what is in that table.
Consider renaming to something like:
Relation to Magento releases
dshevtsov
suggested changes
May 21, 2019
Co-Authored-By: Dmitry Shevtsov <[email protected]>
Co-Authored-By: Dmitry Shevtsov <[email protected]>
Co-Authored-By: Dmitry Shevtsov <[email protected]>
dshevtsov
approved these changes
May 21, 2019
| @@ -56,3 +55,14 @@ It MAY include patch level changes. Patch version MUST be reset to 0 when minor | |||
| Major version **X** MUST be incremented for a release that introduces backward incompatible changes. | |||
| A major release can also include minor and patch level changes. | |||
| You must reset the patch and minor version to 0 when you change the major version. | |||
|
|
|||
| ## Magento 2 compatibility | |||
There was a problem hiding this comment.
Suggested change
| ## Magento 2 compatibility | |
| ## Magento 2 compatibility |
tomreece
approved these changes
May 22, 2019
magento-devops-reposync-svc
pushed a commit
that referenced
this pull request
Nov 16, 2023
Merging master back to develop .
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds a magento2 -> MFTF version table.
Adds instructions for updating MFTF.