-
Notifications
You must be signed in to change notification settings - Fork 132
MQE-1376: [SPIKE] Investigate Self-Documentation for MFTF #324
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Added some mild documentation for action groups
- Added more information - Made deprecation warning specific to generate:docs
- Added unit tests - Updated functions to facilitate unit testing
- Adding documentation
KevinBKozan
suggested changes
Apr 11, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall looks good, just some minor changes needed + some questions for you
src/Magento/FunctionalTestingFramework/Test/Util/ActionGroupAnnotationExtractor.php
Outdated
Show resolved
Hide resolved
- Making requested review changes
- Correcting Build failures, correcting object instantiation
- Using constants from respective classes
KevinBKozan
suggested changes
Apr 17, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
QA complete, one super small change requested.
- Added output directory to end of command
KevinBKozan
previously approved these changes
Apr 18, 2019
KevinBKozan
approved these changes
Apr 19, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding a command
generate:docs
to allow for local generation of documentation for action groupsDescription
Adding unit tests, documentation and a command to MFTF to enable self-documentation.
Contribution checklist