Skip to content

MQE-1117: dontSeeJsError does not catch JS errors #242

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 3, 2018
Merged

MQE-1117: dontSeeJsError does not catch JS errors #242

merged 1 commit into from
Oct 3, 2018

Conversation

aljcalandra
Copy link
Contributor

  • Added check for null driver to prevent php fatal error

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/verification tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)
  • Changes to Framework doesn't have backward incompatible changes for tests or have related Pull Request with fixes to tests

@aljcalandra
MQE-1117: dontSeeJsError does not catch JS errors
490cd88 
- Added check for null driver to prevent php fatal error
@coveralls
Copy link

Coverage Status

Coverage remained the same at 57.516% when pulling 490cd88 on MQE-1117-2 into a4e0a9b on develop.

@aljcalandra aljcalandra merged commit 68c8d68 into develop Oct 3, 2018
@aljcalandra aljcalandra deleted the MQE-1117-2 branch October 3, 2018 14:24
magento-devops-reposync-svc pushed a commit that referenced this pull request Nov 16, 2022
@KevinBKozan
Merge pull request #242 from magento-gl/ACQE-4210
e38b5fa 
 ACQE-4210 : Php update 8.2.0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KevinBKozan KevinBKozan KevinBKozan approved these changes

@jilu1 jilu1 Awaiting requested review from jilu1

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@aljcalandra @coveralls @KevinBKozan