Skip to content

MQE-1043: MFTF force flag should ignore the magento base url even when valid #143

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jun 13, 2018

Conversation

KevinBKozan
Copy link
Contributor

Description

  • the flag --force now completely ignores magento modules when generating.

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/verification tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)
  • Changes to Framework doesn't have backward incompatible changes for tests or have related Pull Request with fixes to tests

…n valid

- ModuleResolver now completely ignores trying to get enabledModules if --force is set
- Shuffled around exception throwing for faster failure
- Fix for MQE-1017 included, exceptions are now more verbose and precise as to when they are thrown.
@coveralls
Copy link

coveralls commented Jun 12, 2018

Coverage Status

Coverage decreased (-1.5%) to 57.316% when pulling 25a32bd on MQE-1043 into 37de3a1 on develop.

…n valid

- Unit test updates to maintain coverage.
@KevinBKozan KevinBKozan merged commit 371f352 into develop Jun 13, 2018
@KevinBKozan KevinBKozan deleted the MQE-1043 branch June 13, 2018 13:54
magento-devops-reposync-svc pushed a commit that referenced this pull request Dec 16, 2021
MQE-3155: Prepare MFTF 3.7.3 release
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants