Skip to content

Allow ActionGroup arguments to have a defaultValue of another argument #300

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
navarr opened this issue Jan 22, 2019 · 2 comments
Closed

Comments

@navarr
Copy link
Member

navarr commented Jan 22, 2019

ActionGroup parameters should be able to contain a defaultValue that is filled by another argument. An example scenario:

<actionGroup name="CheckProductPricingOnStorefrontOrderReview">
    <arguments>
        <argument name="product"/>
        <argument type="string" name="priceInclTax"/>
        <argument type="string" name="priceExclTax"/>
        <argument type="string" name="subtotalExclTax" defaultValue="{{priceExclTax}}"/>
        <argument type="string" name="subtotalInclTax" defaultValue="{{priceInclTax}}"/>
    </arguments>

    <see stepKey="seeProductPriceExclTax" userInput="{{priceExclTax}}" selector="{{StorefrontCustomerOrderViewSection.productPriceExclTaxByName(product.name)}}"/>
    <see stepKey="seeProductPriceInclTax" userInput="{{priceInclTax}}" selector="{{StorefrontCustomerOrderViewSection.productPriceInclTaxByName(product.name)}}"/>

    <see stepKey="seeProductSubtotalExclTax" userInput="{{subtotalExclTax}}" selector="{{StorefrontCustomerOrderViewSection.productSubtotalExclTaxByName(product.name)}}"/>
    <see stepKey="seeProductSubtotalInclTax" userInput="{{subtotalInclTax}}" selector="{{StorefrontCustomerOrderViewSection.productSubtotalInclTaxByName(product.name)}}"/>
</actionGroup>
@jilu1
Copy link
Contributor

jilu1 commented Oct 25, 2019

Hello @navarr, thank you for your reporting! We've created an internal ticket https://jira.corp.magento.com/browse/MQE-1859 for this feature enhancement. We will keep you updated with progress and feedback through this PR.

@tomreece
Copy link
Contributor

Discussed internally. Won't do at this time.

magento-devops-reposync-svc pushed a commit that referenced this issue Jun 1, 2023
 Release Checklist :MFTF  4.3.1 release
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants