Move LineLength from ruleset to sniff (fixes #36) #50
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
mzeis
force-pushed
the
36-LineLength-FixLimit
branch
from
3127c42 to
73e4e1b
Compare
lenaorobei
approved these changes
Mar 4, 2019
Contributor
|
@mzeis thank you for fixing this! |
magento-devops-reposync-svc
pushed a commit
that referenced
this pull request
Sep 2, 2021
…-coding-standard-230 [Imported] AC-659 Create phpcs static check for ModuleXMLTest
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As suggested in #36 (comment), I moved the property declaration from the ruleset to the sniff itself.
I added an unit test but #6 should stay open as not all scenarios are covered yet.