Skip to content

provide possible solution feedback for discouraged functions #101

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

provide possible solution feedback for discouraged functions #101

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
49bdbbc
provide possible solution feedback for discouraged functions
philippsander May 22, 2019
28fbcd8
Update Magento2/Sniffs/Functions/DiscouragedFunctionSniff.php
philippsander May 23, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions Magento2/Sniffs/Functions/DiscouragedFunctionSniff.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ class DiscouragedFunctionSniff extends ForbiddenFunctionsSniff
'^chroot$' => null,
'^com_load_typelib$' => null,
'^copy$' => null,
'^curl_.*$' => null,
'^curl_.*$' => '\Magento\Framework\HTTP\Adapter\Curl',
'^cyrus_connect$' => null,
'^dba_.*$' => null,
'^dbase_.*$' => null,
Expand All @@ -53,7 +53,7 @@ class DiscouragedFunctionSniff extends ForbiddenFunctionsSniff
'^dcngettext$' => null,
'^dgettext$' => null,
'^dio_.*$' => null,
'^dirname$' => null,
'^dirname$' => '\Magento\Framework\Filesystem\Io\File::getPathInfo [\'dirname\']',
'^dngettext$' => null,
'^domxml_.*$' => null,
'^fbsql_.*$' => null,
Expand Down Expand Up @@ -140,7 +140,7 @@ class DiscouragedFunctionSniff extends ForbiddenFunctionsSniff
'^time_nanosleep$' => null,
'^base64_decode$' => null,
'^base_convert$' => null,
'^basename$' => null,
'^basename$' => '\Magento\Framework\Filesystem\Io\File::getPathInfo [\'basename\']',
'^chr$' => null,
'^convert_cyr_string$' => null,
'^dba_nextkey$' => null,
Expand Down