Skip to content

MCLOUD-6958: Command cache:evict does not support L2 cache configuration #44

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Sep 23, 2020
Merged

MCLOUD-6958: Command cache:evict does not support L2 cache configuration #44

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9cc8966
MCLOUD-6958: Command cache:evict does not support L2 cache configuration
yvoronoy Sep 18, 2020
fd0f5ae
MCLOUD-6958: Command cache:evict does not support L2 cache configuration
yvoronoy Sep 21, 2020
6d04c1f
MCLOUD-6958: Command cache:evict does not support L2 cache configuration
yvoronoy Sep 22, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
47 changes: 39 additions & 8 deletions Model/Cache/Evictor.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,11 +60,7 @@ public function evict(): int
$name
));

if (!isset(
$cacheConfig['backend_options']['server'],
$cacheConfig['backend_options']['port'],
$cacheConfig['backend_options']['database']
)) {
if (!$this->isCacheConfigValid($cacheConfig)) {
$this->logger->debug(sprintf(
'Cache config for database "%s" config is not valid',
$name
Expand All @@ -74,9 +70,9 @@ public function evict(): int
}

$dbKeys = $this->run(
(string)$cacheConfig['backend_options']['server'],
(int)$cacheConfig['backend_options']['port'],
(int)$cacheConfig['backend_options']['database']
(string)$this->getCacheConfigValue($name, $cacheConfig, 'server'),
(int)$this->getCacheConfigValue($name, $cacheConfig, 'port'),
(int)$this->getCacheConfigValue($name, $cacheConfig, 'database')
);
$evictedKeys += $dbKeys;

Expand All @@ -86,6 +82,41 @@ public function evict(): int
return $evictedKeys;
}

/**
* Get Cache Config Value
*
* @param array $cacheConfig
* @param string $configKey
* @return string
*/
private function getCacheConfigValue($cacheConfig, $configKey)
Copy link

@NadiyaS NadiyaS Sep 21, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add return type declaration to new functions
private function getCacheConfigValue($cacheConfig, $configKey): string
and for isCacheConfigValid()

Copy link
Contributor Author

@yvoronoy yvoronoy Sep 21, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@NadiyaS
CR Notes - fixed

{
if (isset($cacheConfig['backend_options'][$configKey])) {
return $cacheConfig['backend_options'][$configKey];
}
if (isset($cacheConfig['backend_options']['remote_backend_options'][$configKey])) {
return $cacheConfig['backend_options']['remote_backend_options'][$configKey];
}
return '';
}

/**
* Validate Cache Configuration
*
* @param $cacheConfig
* @return bool
*/
private function isCacheConfigValid($cacheConfig)
{
if ($this->getCacheConfigValue($cacheConfig, 'server')
&& $this->getCacheConfigValue($cacheConfig, 'port')
&& $this->getCacheConfigValue($cacheConfig, 'database')
) {
return true;
}
return false;
}

/**
* @param string $host
* @param int $port
Expand Down