Skip to content
This repository was archived by the owner on Nov 19, 2024. It is now read-only.

Add data file and template for MFTF Action Groups reference #5177

Merged
merged 11 commits into from
Aug 16, 2019

Conversation

dobooth
Copy link
Contributor

@dobooth dobooth commented Aug 13, 2019

Purpose of this pull request

This pull request (PR) adds a data yml file and an include file for a MFTF Actiongroup reference file.
The actual MFTF topic will go in another PR and then that will be followed by the TOC entry.

Affected DevDocs pages

N/A

@dobooth dobooth added the Technical Updates to the code or processes that alter the technical content of the doc label Aug 13, 2019
@dobooth dobooth self-assigned this Aug 13, 2019
@dobooth dobooth requested a review from dshevtsov August 15, 2019 15:05
@dshevtsov
Copy link
Collaborator

The PR with actual topic: magento/magento2-functional-testing-framework#419

Copy link
Collaborator

@dshevtsov dshevtsov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. Move style from the MFTF topic to devdocs/common/css/devdocs.css and rename it so that it could be reused in other reference topics (confirmed by @belbiy ):
/* Reference styles */
.ref-list {
  margin-bottom: 2.5em;
}

.ref-list dt{
  font-weight:500;
}
  1. Move the template to includes and the assignment to the topic similar to cli reference topics implementation
  2. Move the data to _data/codebase/mftf/action-groups.yml.

@dshevtsov dshevtsov changed the title Adds data file and include for MFTF Actiongroup reference. Add data file and template for MFTF Action Groups reference Aug 16, 2019
@dshevtsov dshevtsov self-requested a review August 16, 2019 14:02
@dobooth
Copy link
Contributor Author

dobooth commented Aug 16, 2019

running tests

@dobooth
Copy link
Contributor Author

dobooth commented Aug 16, 2019

running tests

@dobooth dobooth merged commit 1f67d39 into master Aug 16, 2019
@ghost
Copy link

ghost commented Aug 16, 2019

Hi @dobooth, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@dobooth dobooth deleted the db_actiongroups branch August 16, 2019 14:57
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Technical Updates to the code or processes that alter the technical content of the doc
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants