Skip to content

April 3, 2019 #137

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
lenaorobei opened this issue Apr 2, 2019 · 3 comments
Closed

April 3, 2019 #137

lenaorobei opened this issue Apr 2, 2019 · 3 comments
Labels
meeting notes Topic requests and notes from meetings

Comments

@lenaorobei
Copy link
Contributor

lenaorobei commented Apr 2, 2019

Please add your topic as a comment to the issue. Use following format:
Topic description and link to PR, if any (duration in min)

🎥 (Recording](https://youtu.be/UCNATY5ZIfU)

@lenaorobei
Copy link
Contributor Author

@melnikovi melnikovi added the meeting notes Topic requests and notes from meetings label Apr 2, 2019
@joshuaadickerson
Copy link

@buskamuza
Copy link
Contributor

buskamuza commented Apr 3, 2019

@melnikovi : adding an optional argument in constructor.

  • @akaplya : currently it's a MINOR change, we should not do such changes in Magento patch releases
  • @buskamuza : we should distinguish classes that have to be extended (because there is not way around it) and classes that can use composition (as intended). See also Added a section about breaking changes that require approval devdocs#4156
    • @larsroettig : there are many extensions that inherit from Magento core classes
  • @kandy : ext developers should follow best practices and write tests to validate against new Magento releases to be sure that the extension is not broken

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
meeting notes Topic requests and notes from meetings
Projects
None yet
Development

No branches or pull requests

4 participants