This repository was archived by the owner on Dec 21, 2024. It is now read-only.
Fix inclusion of py.typed in pip packages
#168
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The keys in the `package_data` dictionary in `setup.py` need to be package names, not source directories, for the data files to be packaged correctly.
madzak
approved these changes
Feb 21, 2023
|
Thanks for the fix! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
py.typedmarker file, which indicates that the code has type annotations, is currently missing from the package files published on pypi. The reason is that thepackage_datadictionary insetup.pycurrently uses the key"src/pythonjsonlogger"where a package name, not a directory, is required (see the example in the documentation).When the package name is used instead,
py.typedgets packaged correctly.