This repository was archived by the owner on Feb 8, 2023. It is now read-only.
Update last_seen pref when showing notification #36
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Right now, `last_seen` gets updated only if it's blank, and then never again. That's fine for `first_seen`, but `last_seen` should continually update every time the notification window appears; otherwise, the `days_between_notifications` configuration is broken.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now,
last_seengets updated only if it's blank, and then never again.That's fine for
first_seen, butlast_seenshould continually update every time the notification window appears; otherwise, thedays_between_notificationsconfiguration is broken.Addresses this issue:
#34