This repository was archived by the owner on Feb 8, 2023. It is now read-only.
Set last_seen even if not blank #31
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The code as it's written now will never update
last_seenunless it's blank. So it will be set once, and then never updated again. That effectively breaks thedays_between_notificationpreference, because the span betweenlast_seenand now will get only bigger as time goes by, and so the notifications will keep popping up every half hour.This PR eliminates the check for whether the
last_seenpref is blank, and just updateslast_seenregardless.Since right before this snippet of code, there is an
exit 0if thedays_between_notificationssetting is respected,last_seenwill not be updated if it's been less than the number of days between notifications.