Skip to content

Conversation

sebacruz
Copy link

This change makes the package work again.

@ricpelo
Copy link

ricpelo commented Aug 12, 2016

Related to issue #40 ?

@sebacruz
Copy link
Author

Oh, yeah! I forgot to point that.

@ricpelo
Copy link

ricpelo commented Aug 12, 2016

I'm totally newbie. What can I do in order to test it inside Atom?

@ricpelo
Copy link

ricpelo commented Aug 17, 2016

Applying this patch, the package loads but the panel shows blank. DeprecationCop shows error messages about using deprecated calls. Using Atom 1.9.8.

@sebacruz
Copy link
Author

You receive the same error with any file?

I was able to reproduce that error with some classes (like this) in [email protected] with [email protected] and find out that this package throws the following errors:

php-integrator-symbol-viewer/lib/Main.js:124

Uncaught (in promise) TypeError: Failed to execute 'appendChild' on 'Node': parameter 1 is not of type 'Node'.

php-integrator-symbol-viewer/lib/ConstantDetailsView.js:10

Uncaught (in promise) TypeError: Cannot read property 'resolvedType' of undefined

I didn't have the time to debug a little bit more yet.

@ricpelo
Copy link

ricpelo commented Aug 20, 2016

Thanks for your time, @sebacruz. I've reported the deprecation issue in #47.

@geekosaurusR3x geekosaurusR3x mentioned this pull request Nov 18, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants