Skip to content

Support GHC 9.0 #356

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 11 commits into from
Closed

Support GHC 9.0 #356

wants to merge 11 commits into from

Conversation

tfausak
Copy link
Collaborator

@tfausak tfausak commented Oct 20, 2021

This will fix #352, but it's very much a work in progress.

stack.yaml Outdated
Comment on lines 11 to 13
# In the dependencies for czipwith-1.0.1.3:
# base-4.15.0.0 from stack configuration does not match >=4.11 && <4.15
# template-haskell-2.17.0.0 from stack configuration does not match >=2.9 && <2.17
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

czipwith fails to build because of changes to template-haskell:

czipwith> /tmp/stack-7a145276237e5cc0/czipwith-1.0.1.3/src/Data/CZipWith.hs:226:13: error:
czipwith>     • The constructor ‘PlainTV’ should have 2 arguments, but has been given 1
czipwith>     • In the pattern: PlainTV n
czipwith>       In a case alternative: PlainTV n -> n
czipwith>       In the expression:
czipwith>         case _tyvarbnd of
czipwith>           PlainTV n -> n
czipwith>           KindedTV n _ -> n
czipwith>     |       
czipwith> 226 |             PlainTV n    -> n
czipwith>     |             ^^^^^^^^^

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, that was easy 😄 lspitzner/czipwith#2

@tfausak tfausak mentioned this pull request Oct 20, 2021
@jneira
Copy link
Contributor

jneira commented Oct 20, 2021

Many thanks for take care, imagining how cumbersome is to have to keep up to date all these packages

@tfausak
Copy link
Collaborator Author

tfausak commented Oct 29, 2021

I quickly ran out of easy stuff to fix here. I must say, I'm a bit out of my depth here. Supporting GHC 9 feels possible to me, but maintaining support for earlier versions will be a challenge. I don't normally use CPP, and there are lots of little changes to paper over. Perhaps this should use ghc-lib-parser, but I think that would require changing ghc-exactprint?

@tfausak
Copy link
Collaborator Author

tfausak commented Oct 29, 2021

GHC 9.2 was just released: https://discourse.haskell.org/t/ghc-9-2-1-released/3527

@tfausak
Copy link
Collaborator Author

tfausak commented Oct 29, 2021

@jneira: Question for you about HLS integration: Does Brittany need to support all the same versions of HLS in order to be bundled with it? I would much rather support a single version of GHC and provide static binaries if that's possible.

@jneira
Copy link
Contributor

jneira commented Oct 30, 2021

I am afraid that is the case, each hls version is shipped for each supported ghc.

@tfausak tfausak mentioned this pull request Nov 2, 2021
@svobot svobot mentioned this pull request Nov 3, 2021
@tfausak
Copy link
Collaborator Author

tfausak commented Nov 6, 2021

Closing this in favor of #357.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support for ghc-9.0.1
2 participants