`Development`: Update server dependencies to Spring Boot 3, Spring Framework 6, Spring Cloud 4, Hibernate 6 #5889

krusche · 2022-11-26T14:47:44Z

CURRENTLY BLOCKED

Checklist

I tested all changes and their related features with all corresponding user types on a test server.
I chose a title conforming to the naming conventions for pull requests.

Motivation and Context

We should stay up to date.

Description

Steps for Testing

Developers should test the development setup, starting the server and client application and communicating
Testers should click through most views of the Artemis application and review if you notice issues while testing different CRUD functionality

Review Progress

Test Coverage

no changes

Screenshots

no UI changes

codecov-commenter · 2022-11-26T15:02:21Z

Codecov Report

Base: 84.60% // Head: 75.69% // Decreases project coverage by -8.90% ⚠️

Coverage data is based on head (0b3e187) compared to base (0bed62a).
Patch has no changes to coverable lines.

Additional details and impacted files

@@              Coverage Diff              @@
##             develop    #5889      +/-   ##
=============================================
- Coverage      84.60%   75.69%   -8.91%     
=============================================
  Files           1008     1117     +109     
  Lines          39965    44297    +4332     
  Branches        4273     8363    +4090     
=============================================
- Hits           33811    33530     -281     
- Misses          3792     5599    +1807     
- Partials        2362     5168    +2806

Flag	Coverage Δ
client	`75.69% <ø> (?)`
server	`?`

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
...c/main/java/de/tum/in/www1/artemis/ArtemisApp.java
...e/tum/in/www1/artemis/config/ApiVersionFilter.java
...tum/in/www1/artemis/config/CacheConfiguration.java
...m/in/www1/artemis/config/JacksonConfiguration.java
...in/www1/artemis/config/LiquibaseConfiguration.java
...ava/de/tum/in/www1/artemis/config/MetricsBean.java
...1/artemis/config/PublicResourcesConfiguration.java
...www1/artemis/config/RestTemplateConfiguration.java
...tum/in/www1/artemis/config/SAML2Configuration.java
...de/tum/in/www1/artemis/config/SAML2Properties.java
... and 2113 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

b-fein · 2022-11-26T15:34:59Z

Fails to start with the gitlab profile:

org.springframework.beans.factory.UnsatisfiedDependencyException:
Error creating bean with name 'artemisInternalAuthenticationProvider' defined in URL [jar:file:/opt/artemis/Artemis.war!/WEB-INF/classes!/de/tum/in/www1/artemis/security/ArtemisInternalAuthenticationProvider.class]:
Unsatisfied dependency expressed through constructor parameter 2:
Error creating bean with name 'userCreationService' defined in URL [jar:file:/opt/artemis/Artemis.war!/WEB-INF/classes!/de/tum/in/www1/artemis/service/user/UserCreationService.class]:
Unsatisfied dependency expressed through constructor parameter 4:
Error creating bean with name 'gitLabUserManagementService' defined in URL [jar:file:/opt/artemis/Artemis.war!/WEB-INF/classes!/de/tum/in/www1/artemis/service/connectors/gitlab/GitLabUserManagementService.class]:
Unsatisfied dependency expressed through constructor parameter 1:
Error creating bean with name 'gitLabApi' defined in class path resource [de/tum/in/www1/artemis/config/connector/GitLabApiConfiguration.class]:
Failed to instantiate [org.gitlab4j.api.GitLabApi]:
Factory method 'gitLabApi' threw exception with message: javax/annotation/Priority

Used in the gitlab4j-library here:
https://github.com/gitlab4j/gitlab4j-api/blob/db8f9254c7b42c68522826318821be8d7bb8b075/src/main/java/org/gitlab4j/api/utils/MaskingLoggingFilter.java#L22

Related: gitlab4j/gitlab4j-api#841

Edit: I’ve prepared a gitlab api jar https://github.com/b-fein/gitlab4j-api/packages/1733022 (Assets > gitlab4j-api-5.0.2.jar) that uses jakarta. Not yet tested: Can probably be included by storing that in lib/ and in build.gradle: implementation files("lib/gitlab4j-api-5.0.2.jar").

Strohgelaender · 2022-11-26T17:16:19Z

src/main/java/de/tum/in/www1/artemis/config/ApiVersionFilter.java

-import javax.servlet.*;
-import javax.servlet.http.HttpServletRequest;
-import javax.servlet.http.HttpServletResponse;
-
 import org.slf4j.Logger;
 import org.slf4j.LoggerFactory;
 import org.springframework.beans.factory.annotation.Value;
 import org.springframework.context.annotation.Profile;
 import org.springframework.stereotype.Component;

+import jakarta.servlet.*;
+import jakarta.servlet.http.HttpServletRequest;
+import jakarta.servlet.http.HttpServletResponse;
+


This PR contains a lot of import-order changes like here. Are these on purpose?

artemis-spotless.importorder probably needs to be adapted if the renamed dependencies should be placed in their own imports section like before.

Currently, javax has its own special case here. It would be interesting to know if this was due to the similar name to java or if these imports should generally stay on top. In the case of 2) we should probably adapt the file.

krusche · 2022-11-26T17:46:23Z

Fails to start with the gitlab profile:
org.springframework.beans.factory.UnsatisfiedDependencyException:
Error creating bean with name 'artemisInternalAuthenticationProvider' defined in URL [jar:file:/opt/artemis/Artemis.war!/WEB-INF/classes!/de/tum/in/www1/artemis/security/ArtemisInternalAuthenticationProvider.class]:
Unsatisfied dependency expressed through constructor parameter 2:
Error creating bean with name 'userCreationService' defined in URL [jar:file:/opt/artemis/Artemis.war!/WEB-INF/classes!/de/tum/in/www1/artemis/service/user/UserCreationService.class]:
Unsatisfied dependency expressed through constructor parameter 4:
Error creating bean with name 'gitLabUserManagementService' defined in URL [jar:file:/opt/artemis/Artemis.war!/WEB-INF/classes!/de/tum/in/www1/artemis/service/connectors/gitlab/GitLabUserManagementService.class]:
Unsatisfied dependency expressed through constructor parameter 1:
Error creating bean with name 'gitLabApi' defined in class path resource [de/tum/in/www1/artemis/config/connector/GitLabApiConfiguration.class]:
Failed to instantiate [org.gitlab4j.api.GitLabApi]:
Factory method 'gitLabApi' threw exception with message: javax/annotation/Priority
Used in the gitlab4j-library here: https://github.com/gitlab4j/gitlab4j-api/blob/db8f9254c7b42c68522826318821be8d7bb8b075/src/main/java/org/gitlab4j/api/utils/MaskingLoggingFilter.java#L22

Related: gitlab4j/gitlab4j-api#841

Edit: I’ve prepared a gitlab api jar https://github.com/b-fein/gitlab4j-api/packages/1733022 (Assets > gitlab4j-api-5.0.2.jar) that uses jakarta. Not yet tested: Can probably be included by storing that in lib/ and in build.gradle: implementation files("lib/gitlab4j-api-5.0.2.jar").

Yes, this could be a good temporary solution until gitlab4j provides their own release.
How did you create the new jar? (I saw some tools which can do that but did not try them out yet)
We have a similar problem with org.imsglobal:basiclti-util:1.2.0
Any chance you could create a Jakarta compatible jar here as well? :-)

b-fein · 2022-11-26T17:53:57Z

How did you create the new jar?

In this case just changing the dependencies and then a search-and-replace: s/javax/jakarta/g https://github.com/b-fein/gitlab4j-api/commit/4299525969b9d067dcb50d48086eea3a719ee10b

This reverts commit 17c7404.

krusche · 2023-01-09T20:47:44Z

Great, thank you 👍🏻 these are good news.

At the moment I am not happy yet with some Hibernate 6 issues related to quizzes and the second level cache. This might delay the integration of this PR for a couple of weeks, except someone could help me fixing those issues.

In addition, we would need to get the e2e tests running successfully again and need extensive manual testing

github-actions · 2023-01-19T12:04:31Z

There hasn't been any activity on this pull request recently. Therefore, this pull request has been automatically marked as stale and will be closed if no further activity occurs within seven days. Thank you for your contributions.

krusche · 2023-01-26T16:01:30Z

Currently blocked by bugs in Hibernate 6.1.6, which will hopefully be resolved in the near future (either 6.1.7 or 6.2.0)

….3 launches

… in server)

ge65cer · 2023-02-15T07:13:43Z

@krusche Hibernate Core 6.1.7 has been released, might be worthwhile to check if the bugs are fixed.

julian-christl · 2023-04-19T10:24:52Z

build.gradle

+    // Note: gitlab4j-api does not work with jakarta yet, so we built our own custom version and declare its transitive dependencies below
+//    implementation "org.gitlab4j:gitlab4j-api:5.0.1"
+    implementation files("lib/gitlab4j-api-5.0.2.jar")
+    // The following 5 + 2 dependencies are explicitly integrated as transitive dependencies of gitlab4j-api-5.0.2.jar
+    implementation "org.glassfish.jersey.inject:jersey-hk2:${jersey_version}"
+    implementation "org.glassfish.jersey.core:jersey-client:${jersey_version}"
+    implementation "org.glassfish.jersey.connectors:jersey-apache-connector:${jersey_version}"
+    implementation "org.glassfish.jersey.media:jersey-media-multipart:${jersey_version}"
+    implementation "org.glassfish.jersey.media:jersey-media-json-jackson:${jersey_version}"
+    implementation "jakarta.activation:jakarta.activation-api:${activation_version}"
+    implementation "jakarta.platform:jakarta.jakartaee-api:${jakartaee_version}"


v6.0.0-rc.1 now supports Jakarta: https://github.com/gitlab4j/gitlab4j-api/releases/tag/gitlab4j-api-6.0.0-rc.1

krusche · 2023-06-14T10:40:22Z

I will close this PR for now, because we are still blocked by issues with the breaking changes in Hibernate.

Stephan Krusche added 2 commits November 26, 2022 11:25

Update server dependencies

ad45d4e

update to Spring Boot 3, Spring Framework 6, Hibernate 6

131c7ea

krusche added this to the 6.0.0 milestone Nov 26, 2022

github-actions bot assigned krusche Nov 26, 2022

github-actions bot added documentation server Pull requests that update Java code. (Added Automatically!) tests labels Nov 26, 2022

krusche had a problem deploying to artemistest5 November 26, 2022 14:58 Failure

Development: Fix client style after lint update

92dd938

github-actions bot added the client Pull requests that update TypeScript code. (Added Automatically!) label Nov 26, 2022

krusche added dependencies Pull requests that update a dependency file chore config-change Pull requests that change the config in a way that they require a deployment via Ansible. and removed client Pull requests that update TypeScript code. (Added Automatically!) labels Nov 26, 2022

fix testing logback config

8dd2fa7

github-actions bot added the client Pull requests that update TypeScript code. (Added Automatically!) label Nov 26, 2022

b-fein force-pushed the chore/spring-boot-3 branch from e68d6c5 to 8dd2fa7 Compare November 26, 2022 17:11

Strohgelaender reviewed Nov 26, 2022

View reviewed changes

b-fein mentioned this pull request Dec 1, 2022

Development: Refactor deprecated Spring security configuration #5912

Closed

13 tasks

Stephan Krusche and others added 7 commits December 3, 2022 14:01

use updated gitlab4j library, replace BadRequest with BadRequestAlert

9d53918

add Gitlab4j jar including dependencies

17c7404

Revert "add Gitlab4j jar including dependencies"

420386a

This reverts commit 17c7404.

add transitive dependencies and fix checkstyle issues

b9a95f0

integrate lti library with correct jakarta import

e289c11

fix small issues

0c604d0

fix java doc issues

ce6c957

krusche modified the milestones: 6.0.0, 6.1.0 Jan 11, 2023

github-actions bot added the stale label Jan 19, 2023

Strohgelaender added no-stale and removed stale labels Jan 19, 2023

Manuel Manso added 3 commits January 22, 2023 15:23

Fix updateOnlineCourseConfiguration not saving changes

13aa26c

Replace AuthorizationGrantType AuthorizationCode with Implicit

b4260bd

Use older version of spring-security-lti13

6ea18c4

krusche mentioned this pull request Jan 25, 2023

Development: Add API versioning #5826

Closed

13 tasks

krusche added the blocked label Jan 26, 2023

julian-christl and others added 7 commits January 28, 2023 11:56

Development: Add API versioning (#6057)

70afa5d

Use latest version of library

dc3f48d

Update build.gradle to use updated version of library (also remote)

165f58c

Use Authorization_Code grant instead of deprecated Implicit for LTI 1…

2bb6fe1

….3 launches

Apply fix in #6129; Do not verify matching state in client (also done…

44cfec9

… in server)

Fix lti13launch client test - apply #6129 fix

7538633

Update to Gradle 8.0

13fda3b

krusche modified the milestones: 6.1.0, 6.2.0 Mar 4, 2023

julian-christl reviewed Apr 19, 2023

View reviewed changes

krusche removed this from the 6.2.2 milestone Jun 11, 2023

krusche closed this Jun 14, 2023

julian-christl deleted the chore/spring-boot-3 branch March 27, 2024 16:40

julian-christl restored the chore/spring-boot-3 branch March 27, 2024 21:12

krusche deleted the chore/spring-boot-3 branch April 28, 2024 09:51

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

`Development`: Update server dependencies to Spring Boot 3, Spring Framework 6, Spring Cloud 4, Hibernate 6 #5889

`Development`: Update server dependencies to Spring Boot 3, Spring Framework 6, Spring Cloud 4, Hibernate 6 #5889

krusche commented Nov 26, 2022 •

edited

Loading

Uh oh!

codecov-commenter commented Nov 26, 2022 •

edited

Loading

Uh oh!

b-fein commented Nov 26, 2022 •

edited

Loading

Uh oh!

Strohgelaender Nov 26, 2022 •

edited

Loading

Uh oh!

b-fein Nov 26, 2022

Uh oh!

Strohgelaender Nov 26, 2022

Uh oh!

krusche commented Nov 26, 2022

Uh oh!

b-fein commented Nov 26, 2022

Uh oh!

krusche commented Jan 9, 2023

Uh oh!

github-actions bot commented Jan 19, 2023

Uh oh!

krusche commented Jan 26, 2023

Uh oh!

ge65cer commented Feb 15, 2023

Uh oh!

julian-christl Apr 19, 2023

Uh oh!

krusche commented Jun 14, 2023

Uh oh!

Uh oh!

Development: Update server dependencies to Spring Boot 3, Spring Framework 6, Spring Cloud 4, Hibernate 6 #5889

Development: Update server dependencies to Spring Boot 3, Spring Framework 6, Spring Cloud 4, Hibernate 6 #5889

Conversation

krusche commented Nov 26, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

CURRENTLY BLOCKED

Checklist

Motivation and Context

Description

Steps for Testing

Review Progress

Test Coverage

Screenshots

Uh oh!

codecov-commenter commented Nov 26, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

b-fein commented Nov 26, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Strohgelaender Nov 26, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

b-fein Nov 26, 2022

Choose a reason for hiding this comment

Uh oh!

Strohgelaender Nov 26, 2022

Choose a reason for hiding this comment

Uh oh!

krusche commented Nov 26, 2022

Uh oh!

b-fein commented Nov 26, 2022

Uh oh!

krusche commented Jan 9, 2023

Uh oh!

github-actions bot commented Jan 19, 2023

Uh oh!

krusche commented Jan 26, 2023

Uh oh!

ge65cer commented Feb 15, 2023

Uh oh!

julian-christl Apr 19, 2023

Choose a reason for hiding this comment

Uh oh!

krusche commented Jun 14, 2023

Uh oh!

Uh oh!

`Development`: Update server dependencies to Spring Boot 3, Spring Framework 6, Spring Cloud 4, Hibernate 6 #5889

`Development`: Update server dependencies to Spring Boot 3, Spring Framework 6, Spring Cloud 4, Hibernate 6 #5889

krusche commented Nov 26, 2022 •

edited

Loading

codecov-commenter commented Nov 26, 2022 •

edited

Loading

b-fein commented Nov 26, 2022 •

edited

Loading

Strohgelaender Nov 26, 2022 •

edited

Loading