Backport 26143 ([manuf] enable patching a single AST config CSR) #28878
Conversation
pamaury
requested review from
AlexJones0,
alees24,
cfrantz,
jwnrt and
timothytrippel
and removed request for
a team,
alees24,
cfrantz and
timothytrippel
This updates the individualization firmware to enable patching a single AST config CSR based on an address and value stored in flash info page 0. This is activated by a CLI arg `--patch-ast` passed to the orchestrator script. Signed-off-by: Tim Trippel <[email protected]> (cherry picked from commit 2d89b9a)
pamaury
force-pushed
the
backport_26143
branch
from
8000071 to
44a82cf
Compare
AlexJones0
left a comment
AlexJones0
left a comment
There was a problem hiding this comment.
LGTM - I'm assuming from context that we no longer disable the OTP runtime checks because we can give this patch for environments that would fail them? Or maybe it was just stale? The lack of an original comment on this makes it a bit hard to understand.
I've left one comment on the original code, feel free to address or delay if convenient for backporting efforts.
| parser.add_argument( | ||
| "--patch-ast", | ||
| action="store_true", | ||
| default=False, |
There was a problem hiding this comment.
Nit: (on original PR, not backport code) - You don't need default=False for an argparse argument with action="store_true". See the docs:
'store_true'and'store_false'- These are special cases of'store_const'that respectively store the valuesTrueandFalsewith default values ofFalseandTrue:
Looking at the orchestrator, it seems like this is repeated for many fields here.
There was a problem hiding this comment.
I created an issue based on this comment.
3 participants
Backport #26143