Skip to content

chore: replace jade with pug #10990

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 9, 2025
Merged

chore: replace jade with pug #10990

merged 2 commits into from
Jun 9, 2025

Conversation

dhmlau
Copy link
Member

@dhmlau dhmlau commented Jun 3, 2025

This PR fixes a few things:

  • jade is no longer maintained, and use pug instead.
  • [email protected] is deprecated: Use @unicode/unicode-10.0.0 instead.
  • CI for macos-latest with Node.js 22 always fails because distutils (python) is not installed. This PR fixes the CI by installing python.

Checklist

  • DCO (Developer Certificate of Origin) signed in all commits
  • npm test passes on your machine
  • New tests added or existing tests modified to cover all changes
  • Code conforms with the style guide
  • API Documentation in code was updated
  • Documentation in /docs/site was updated
  • Affected artifact templates in packages/cli were updated
  • Affected example projects in examples/* were updated

👉 Check out how to submit a PR 👈

@dhmlau dhmlau requested a review from raymondfeng as a code owner June 3, 2025 23:40
@dhmlau dhmlau force-pushed the remove-jade branch 2 times, most recently from 684a7ac to 7c84a16 Compare June 4, 2025 01:18
@coveralls
Copy link

coveralls commented Jun 4, 2025

Pull Request Test Coverage Report for Build 15431454063

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall first build on remove-jade at 54.281%

Totals Coverage Status
Change from base Build 15426244157: 54.3%
Covered Lines: 9530
Relevant Lines: 12434

💛 - Coveralls

@dhmlau dhmlau requested a review from samarpanB June 5, 2025 19:04
@dhmlau dhmlau merged commit 393cbf6 into master Jun 9, 2025
13 checks passed
@dhmlau dhmlau deleted the remove-jade branch June 9, 2025 13:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants