Skip to content

ci: switch from travis to github actions #439

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 42 commits into from
Closed

ci: switch from travis to github actions #439

wants to merge 42 commits into from

Conversation

agnes512
Copy link
Contributor

Signed-off-by: Agnes Lin [email protected]

Checklist

  • DCO (Developer Certificate of Origin) signed in all commits
  • npm test passes on your machine
  • New tests added or existing tests modified to cover all changes
  • Code conforms with the style guide
  • Commit messages are following our guidelines

@frbuceta frbuceta mentioned this pull request Feb 18, 2021
Closed
3 tasks
@agnes512 agnes512 force-pushed the gh-actions branch 3 times, most recently from 16547a3 to 7812e62 Compare February 20, 2021 00:19
@agnes512 agnes512 force-pushed the gh-actions branch 2 times, most recently from b62b30a to 243a0f6 Compare February 20, 2021 02:41
@bajtos bajtos mentioned this pull request Mar 19, 2021
Closed
12 tasks
bajtos
bajtos reviewed Mar 19, 2021
View reviewed changes
Copy link
Member

@bajtos bajtos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great initiative 👏🏻

I left few comments to consider, hoping to help you troubleshoot the failing CI.

test/init.js Outdated
password: process.env.MYSQL_PASSWORD || config.password,
database: process.env.MYSQL_DATABASE || 'testdb',
username: process.env.MYSQL_USER || config.username || 'user',
password: process.env.MYSQL_PASSWORD || config.password || 'pass',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It makes me wonder, are cis-jenkins builds failing because the database on cis-jenkins is using the old values (user "test", password "test") and not providing any ENV variables to specify those values explicitly?

What if we reverted changes in this file, would it fix cis-jenkins builds while keeping local dev setup and GH Actions CI working too?

test/init.js Outdated
global.getConfig = function(options) {
const dbConf = {
host: process.env.MYSQL_HOST || config.host || 'localhost',
host: process.env.MYSQL_HOST || config.host || '127.0.0.1',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think forcing the IPv4 localhost is a good idea and we can land this change independently on the rest 👍

.github/workflows/continuous-integration.yaml
Comment on lines +20 to +23
MYSQL_USER: user
MYSQL_PASSWORD: pass
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we can try to use the same values we have in place now?

Suggested change
MYSQL_USER: user
MYSQL_PASSWORD: pass
MYSQL_USER: test
MYSQL_PASSWORD: test

@agnes512
Copy link
Contributor Author

Thanks @bajtos ! Jenkins failed might because I was trying to get GH actions to work. I remember that I couldn't get the right version of MySQL running on Github actions. The default is MySQL 8 and I couldn't get MySQL 5.7 to work properly, and that was frustrating 😂

@agnes512 agnes512 force-pushed the gh-actions branch 3 times, most recently from 8e4ee10 to 5b20dc1 Compare April 11, 2021 04:28
Agnes Lin added 2 commits April 11, 2021 00:58
ci: try mirror
db49925 
Signed-off-by: Agnes Lin <[email protected]>
ci: 3307 + mirror
47b8a93 
Signed-off-by: Agnes Lin <[email protected]>
ci: clean up
3a6c902 
Signed-off-by: Agnes Lin <[email protected]>
Agnes Lin added 12 commits April 11, 2021 21:57
ci: check mysql version
0770f98 
Signed-off-by: Agnes Lin <[email protected]>
ci: socket
dddc4be 
Signed-off-by: Agnes Lin <[email protected]>
ci: socket
369fca5 
Signed-off-by: Agnes Lin <[email protected]>
ci: socket
25c58f8 
Signed-off-by: Agnes Lin <[email protected]>
ci: socket
48a8269 
Signed-off-by: Agnes Lin <[email protected]>
ci: socket
86dd945 
Signed-off-by: Agnes Lin <[email protected]>
ci: socket
0b4c131 
Signed-off-by: Agnes Lin <[email protected]>
ci: socket
309bccb 
Signed-off-by: Agnes Lin <[email protected]>
ci: socket
755a6b2 
Signed-off-by: Agnes Lin <[email protected]>
ci: socket
6be5213 
Signed-off-by: Agnes Lin <[email protected]>
ci: socket
ca7e142 
Signed-off-by: Agnes Lin <[email protected]>
ci: socket
566965d 
Signed-off-by: Agnes Lin <[email protected]>
Agnes Lin added 24 commits April 11, 2021 22:45
ci: start over wirh builtin mysql]
814d718 
Signed-off-by: Agnes Lin <[email protected]>
ci: start over wirh builtin mysql]
7a434ee 
Signed-off-by: Agnes Lin <[email protected]>
ci: start over wirh builtin mysql]
fd50d33 
Signed-off-by: Agnes Lin <[email protected]>
update start over
f1f4200
ci: start over wirh builtin mysql]
d43d2c0 
Signed-off-by: Agnes Lin <[email protected]>
ci: start over wirh builtin mysql]
00609b9 
Signed-off-by: Agnes Lin <[email protected]>
ci: start over wirh builtin mysql]
1aadaec 
Signed-off-by: Agnes Lin <[email protected]>
ci: start over wirh builtin mysql]
7dab0e0 
Signed-off-by: Agnes Lin <[email protected]>
ci: start over wirh builtin mysql]
d3e4810 
Signed-off-by: Agnes Lin <[email protected]>
ci: start over wirh builtin mysql]
b2ecc3a 
Signed-off-by: Agnes Lin <[email protected]>
ci: start over wirh builtin mysql]
7eed6de 
Signed-off-by: Agnes Lin <[email protected]>
ci: start over wirh builtin mysql]
c060849 
Signed-off-by: Agnes Lin <[email protected]>
ci: start over wirh builtin mysql]
3dc42c0 
Signed-off-by: Agnes Lin <[email protected]>
ci: start over wirh builtin mysql]
0fdb90c 
Signed-off-by: Agnes Lin <[email protected]>
ci: start over wirh builtin mysql]
b633f41 
Signed-off-by: Agnes Lin <[email protected]>
ci: start over wirh builtin mysql]
3ab2d7e 
Signed-off-by: Agnes Lin <[email protected]>
ci: start over wirh builtin mysql]
967732a 
Signed-off-by: Agnes Lin <[email protected]>
ci: start over wirh builtin mysql]
c72b12b 
Signed-off-by: Agnes Lin <[email protected]>
ci: start over wirh builtin mysql]
6e82118 
Signed-off-by: Agnes Lin <[email protected]>
ci: start over wirh builtin mysql]
8c2a446 
Signed-off-by: Agnes Lin <[email protected]>
ci: start over wirh builtin mysql]
0459748 
Signed-off-by: Agnes Lin <[email protected]>
ci: start over wirh builtin mysql]
37591a7 
Signed-off-by: Agnes Lin <[email protected]>
ci: start over wirh builtin mysql]
6a3e941 
Signed-off-by: Agnes Lin <[email protected]>
ci: start over wirh builtin mysql]
2b1a7e5 
Signed-off-by: Agnes Lin <[email protected]>
This was referenced Jul 8, 2021
Merged
Merged
@stale
Copy link

stale bot commented Jul 9, 2021

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Jul 9, 2021
@agnes512
Copy link
Contributor Author

See #448

@agnes512 agnes512 closed this Jul 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dhmlau dhmlau Awaiting requested review from dhmlau dhmlau will be requested when the pull request is marked ready for review dhmlau is a code owner

@marioestradarosa marioestradarosa Awaiting requested review from marioestradarosa marioestradarosa will be requested when the pull request is marked ready for review marioestradarosa is a code owner

1 more reviewer

@bajtos bajtos bajtos left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

stale

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@agnes512 @bajtos