-
Notifications
You must be signed in to change notification settings - Fork 199
feat: update Go SDK to accept auth session interface #1488
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codegen Tests418 tests 400 ✅ 44s ⏱️ Results for commit 1cb3e4b. |
jkaster
approved these changes
Aug 9, 2024
Merged
drstrangelooker
pushed a commit
that referenced
this pull request
Aug 12, 2024
🤖 I have created a release *beep* *boop* --- <details><summary>@looker/api-explorer: 0.9.64</summary> ### Dependencies * The following workspace dependencies were updated * dependencies * @looker/code-editor bumped from 0.1.30 to 0.1.31 * @looker/extension-utils bumped from 0.1.40 to 0.1.41 * @looker/run-it bumped from 0.9.63 to 0.9.64 * @looker/sdk bumped from 24.12.1 to 24.14.0 * @looker/sdk-codegen bumped from 21.8.2 to 21.9.0 * devDependencies * @looker/sdk-codegen-scripts bumped from 21.5.20 to 21.5.21 * @looker/sdk-node bumped from 24.12.1 to 24.14.0 </details> <details><summary>@looker/code-editor: 0.1.31</summary> ### Dependencies * The following workspace dependencies were updated * devDependencies * @looker/sdk-codegen bumped from 21.8.2 to 21.9.0 </details> <details><summary>@looker/extension-api-explorer: 22.21.21</summary> ### Dependencies * The following workspace dependencies were updated * dependencies * @looker/api-explorer bumped from 0.9.63 to 0.9.64 * @looker/extension-sdk bumped from 24.12.1 to 24.14.0 * @looker/extension-sdk-react bumped from 24.12.1 to 24.14.0 * @looker/extension-utils bumped from 0.1.40 to 0.1.41 * @looker/run-it bumped from 0.9.63 to 0.9.64 * @looker/sdk bumped from 24.12.1 to 24.14.0 * @looker/sdk-codegen bumped from 21.8.2 to 21.9.0 </details> <details><summary>@looker/extension-playground: 1.0.21</summary> ### Dependencies * The following workspace dependencies were updated * dependencies * @looker/extension-sdk bumped from 24.12.1 to 24.14.0 * @looker/extension-sdk-react bumped from 24.12.1 to 24.14.0 * @looker/sdk bumped from 24.12.1 to 24.14.0 </details> <details><summary>@looker/extension-tile-playground: 1.1.8</summary> ### Dependencies * The following workspace dependencies were updated * dependencies * @looker/extension-sdk bumped from 24.12.1 to 24.14.0 * @looker/extension-sdk-react bumped from 24.12.1 to 24.14.0 * @looker/sdk bumped from 24.12.1 to 24.14.0 </details> <details><summary>@looker/extension-utils: 0.1.41</summary> ### Dependencies * The following workspace dependencies were updated * dependencies * @looker/code-editor bumped from 0.1.30 to 0.1.31 * @looker/extension-sdk bumped from 24.12.1 to 24.14.0 * @looker/extension-sdk-react bumped from 24.12.1 to 24.14.0 * @looker/sdk bumped from 24.12.1 to 24.14.0 </details> <details><summary>@looker/hackathon: 22.21.23</summary> ### Dependencies * The following workspace dependencies were updated * dependencies * @looker/code-editor bumped from 0.1.30 to 0.1.31 * @looker/extension-sdk bumped from 24.12.1 to 24.14.0 * @looker/extension-sdk-react bumped from 24.12.1 to 24.14.0 * @looker/extension-utils bumped from 0.1.40 to 0.1.41 * @looker/sdk bumped from 24.12.1 to 24.14.0 * @looker/wholly-artifact bumped from 0.1.21 to 0.1.22 </details> <details><summary>@looker/run-it: 0.9.64</summary> ### Dependencies * The following workspace dependencies were updated * dependencies * @looker/code-editor bumped from 0.1.30 to 0.1.31 * @looker/extension-utils bumped from 0.1.40 to 0.1.41 * @looker/sdk bumped from 24.12.1 to 24.14.0 * @looker/sdk-codegen bumped from 21.8.2 to 21.9.0 </details> <details><summary>sdk-codegen: 21.9.0</summary> ## [21.9.0](sdk-codegen-v21.8.2...sdk-codegen-v21.9.0) (2024-08-12) ### Features * update Go SDK to accept auth session interface ([#1488](#1488)) ([aee5bf3](aee5bf3)) </details> <details><summary>@looker/sdk-codegen-scripts: 21.5.21</summary> ### Dependencies * The following workspace dependencies were updated * dependencies * @looker/sdk bumped from 24.12.1 to 24.14.0 * @looker/sdk-codegen bumped from 21.8.2 to 21.9.0 * @looker/sdk-node bumped from 24.12.1 to 24.14.0 </details> <details><summary>@looker/wholly-artifact: 0.1.22</summary> ### Dependencies * The following workspace dependencies were updated * dependencies * @looker/sdk bumped from 24.12.1 to 24.14.0 * devDependencies * @looker/sdk-node bumped from 24.12.1 to 24.14.0 </details> <details><summary>@looker/wholly-sheet: 0.5.60</summary> ### Dependencies * The following workspace dependencies were updated * dependencies * @looker/sdk bumped from 24.12.1 to 24.14.0 * devDependencies * @looker/sdk-node bumped from 24.12.1 to 24.14.0 </details> <details><summary>sdk-codegen-all: 24.14.0</summary> ## [24.14.0](sdk-codegen-all-v24.12.1...sdk-codegen-all-v24.14.0) (2024-08-12) ### Features * generate SDKs for Looker 24.14 ([#1490](#1490)) ([1d72127](1d72127)) * update Go SDK to accept auth session interface ([#1488](#1488)) ([aee5bf3](aee5bf3)) </details> <details><summary>looker_sdk: 24.14.0</summary> ## [24.14.0](looker_sdk-v24.12.1...looker_sdk-v24.14.0) (2024-08-12) ### Features * generate SDKs for Looker 24.14 ([#1490](#1490)) ([1d72127](1d72127)) </details> <details><summary>embed-components: 24.14.0</summary> ## [24.14.0](embed-components-v24.12.1...embed-components-v24.14.0) (2024-08-12) ### Miscellaneous Chores * **embed-components:** Synchronize undefined versions ### Dependencies * The following workspace dependencies were updated * dependencies * @looker/embed-services bumped from 24.12.1 to 24.14.0 * @looker/sdk bumped from 24.12.1 to 24.14.0 * devDependencies * @looker/sdk-node bumped from 24.12.1 to 24.14.0 </details> <details><summary>embed-services: 24.14.0</summary> ## [24.14.0](embed-services-v24.12.1...embed-services-v24.14.0) (2024-08-12) ### Miscellaneous Chores * **embed-services:** Synchronize undefined versions ### Dependencies * The following workspace dependencies were updated * dependencies * @looker/sdk bumped from 24.12.1 to 24.14.0 * devDependencies * @looker/sdk-node bumped from 24.12.1 to 24.14.0 </details> <details><summary>extension-sdk: 24.14.0</summary> ## [24.14.0](extension-sdk-v24.12.1...extension-sdk-v24.14.0) (2024-08-12) ### Miscellaneous Chores * **extension-sdk:** Synchronize undefined versions ### Dependencies * The following workspace dependencies were updated * dependencies * @looker/sdk bumped from 24.12.1 to 24.14.0 </details> <details><summary>extension-sdk-react: 24.14.0</summary> ## [24.14.0](extension-sdk-react-v24.12.1...extension-sdk-react-v24.14.0) (2024-08-12) ### Miscellaneous Chores * **extension-sdk-react:** Synchronize undefined versions ### Dependencies * The following workspace dependencies were updated * dependencies * @looker/extension-sdk bumped from 24.12.1 to 24.14.0 * @looker/sdk bumped from 24.12.1 to 24.14.0 </details> <details><summary>sdk: 24.14.0</summary> ## [24.14.0](sdk-v24.12.1...sdk-v24.14.0) (2024-08-12) ### Features * generate SDKs for Looker 24.14 ([#1490](#1490)) ([1d72127](1d72127)) </details> <details><summary>sdk-node: 24.14.0</summary> ## [24.14.0](sdk-node-v24.12.1...sdk-node-v24.14.0) (2024-08-12) ### Miscellaneous Chores * **sdk-node:** Synchronize undefined versions ### Dependencies * The following workspace dependencies were updated * dependencies * @looker/sdk bumped from 24.12.1 to 24.14.0 </details> --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
JCPistell
added a commit
that referenced
this pull request
Aug 29, 2024
This change alters the Go SDK client struct to accept an interface instead of the AuthSession. The interface allows for custom implementations of the RTL package, but since the existing AuthSession fulfills the new interface (its based on the Do method from the current AuthSession after all) this change will be completely transparent to those who are currently using the current AuthSession.
JCPistell
pushed a commit
that referenced
this pull request
Aug 29, 2024
🤖 I have created a release *beep* *boop* --- <details><summary>@looker/api-explorer: 0.9.64</summary> ### Dependencies * The following workspace dependencies were updated * dependencies * @looker/code-editor bumped from 0.1.30 to 0.1.31 * @looker/extension-utils bumped from 0.1.40 to 0.1.41 * @looker/run-it bumped from 0.9.63 to 0.9.64 * @looker/sdk bumped from 24.12.1 to 24.14.0 * @looker/sdk-codegen bumped from 21.8.2 to 21.9.0 * devDependencies * @looker/sdk-codegen-scripts bumped from 21.5.20 to 21.5.21 * @looker/sdk-node bumped from 24.12.1 to 24.14.0 </details> <details><summary>@looker/code-editor: 0.1.31</summary> ### Dependencies * The following workspace dependencies were updated * devDependencies * @looker/sdk-codegen bumped from 21.8.2 to 21.9.0 </details> <details><summary>@looker/extension-api-explorer: 22.21.21</summary> ### Dependencies * The following workspace dependencies were updated * dependencies * @looker/api-explorer bumped from 0.9.63 to 0.9.64 * @looker/extension-sdk bumped from 24.12.1 to 24.14.0 * @looker/extension-sdk-react bumped from 24.12.1 to 24.14.0 * @looker/extension-utils bumped from 0.1.40 to 0.1.41 * @looker/run-it bumped from 0.9.63 to 0.9.64 * @looker/sdk bumped from 24.12.1 to 24.14.0 * @looker/sdk-codegen bumped from 21.8.2 to 21.9.0 </details> <details><summary>@looker/extension-playground: 1.0.21</summary> ### Dependencies * The following workspace dependencies were updated * dependencies * @looker/extension-sdk bumped from 24.12.1 to 24.14.0 * @looker/extension-sdk-react bumped from 24.12.1 to 24.14.0 * @looker/sdk bumped from 24.12.1 to 24.14.0 </details> <details><summary>@looker/extension-tile-playground: 1.1.8</summary> ### Dependencies * The following workspace dependencies were updated * dependencies * @looker/extension-sdk bumped from 24.12.1 to 24.14.0 * @looker/extension-sdk-react bumped from 24.12.1 to 24.14.0 * @looker/sdk bumped from 24.12.1 to 24.14.0 </details> <details><summary>@looker/extension-utils: 0.1.41</summary> ### Dependencies * The following workspace dependencies were updated * dependencies * @looker/code-editor bumped from 0.1.30 to 0.1.31 * @looker/extension-sdk bumped from 24.12.1 to 24.14.0 * @looker/extension-sdk-react bumped from 24.12.1 to 24.14.0 * @looker/sdk bumped from 24.12.1 to 24.14.0 </details> <details><summary>@looker/hackathon: 22.21.23</summary> ### Dependencies * The following workspace dependencies were updated * dependencies * @looker/code-editor bumped from 0.1.30 to 0.1.31 * @looker/extension-sdk bumped from 24.12.1 to 24.14.0 * @looker/extension-sdk-react bumped from 24.12.1 to 24.14.0 * @looker/extension-utils bumped from 0.1.40 to 0.1.41 * @looker/sdk bumped from 24.12.1 to 24.14.0 * @looker/wholly-artifact bumped from 0.1.21 to 0.1.22 </details> <details><summary>@looker/run-it: 0.9.64</summary> ### Dependencies * The following workspace dependencies were updated * dependencies * @looker/code-editor bumped from 0.1.30 to 0.1.31 * @looker/extension-utils bumped from 0.1.40 to 0.1.41 * @looker/sdk bumped from 24.12.1 to 24.14.0 * @looker/sdk-codegen bumped from 21.8.2 to 21.9.0 </details> <details><summary>sdk-codegen: 21.9.0</summary> ## [21.9.0](sdk-codegen-v21.8.2...sdk-codegen-v21.9.0) (2024-08-12) ### Features * update Go SDK to accept auth session interface ([#1488](#1488)) ([aee5bf3](aee5bf3)) </details> <details><summary>@looker/sdk-codegen-scripts: 21.5.21</summary> ### Dependencies * The following workspace dependencies were updated * dependencies * @looker/sdk bumped from 24.12.1 to 24.14.0 * @looker/sdk-codegen bumped from 21.8.2 to 21.9.0 * @looker/sdk-node bumped from 24.12.1 to 24.14.0 </details> <details><summary>@looker/wholly-artifact: 0.1.22</summary> ### Dependencies * The following workspace dependencies were updated * dependencies * @looker/sdk bumped from 24.12.1 to 24.14.0 * devDependencies * @looker/sdk-node bumped from 24.12.1 to 24.14.0 </details> <details><summary>@looker/wholly-sheet: 0.5.60</summary> ### Dependencies * The following workspace dependencies were updated * dependencies * @looker/sdk bumped from 24.12.1 to 24.14.0 * devDependencies * @looker/sdk-node bumped from 24.12.1 to 24.14.0 </details> <details><summary>sdk-codegen-all: 24.14.0</summary> ## [24.14.0](sdk-codegen-all-v24.12.1...sdk-codegen-all-v24.14.0) (2024-08-12) ### Features * generate SDKs for Looker 24.14 ([#1490](#1490)) ([1d72127](1d72127)) * update Go SDK to accept auth session interface ([#1488](#1488)) ([aee5bf3](aee5bf3)) </details> <details><summary>looker_sdk: 24.14.0</summary> ## [24.14.0](looker_sdk-v24.12.1...looker_sdk-v24.14.0) (2024-08-12) ### Features * generate SDKs for Looker 24.14 ([#1490](#1490)) ([1d72127](1d72127)) </details> <details><summary>embed-components: 24.14.0</summary> ## [24.14.0](embed-components-v24.12.1...embed-components-v24.14.0) (2024-08-12) ### Miscellaneous Chores * **embed-components:** Synchronize undefined versions ### Dependencies * The following workspace dependencies were updated * dependencies * @looker/embed-services bumped from 24.12.1 to 24.14.0 * @looker/sdk bumped from 24.12.1 to 24.14.0 * devDependencies * @looker/sdk-node bumped from 24.12.1 to 24.14.0 </details> <details><summary>embed-services: 24.14.0</summary> ## [24.14.0](embed-services-v24.12.1...embed-services-v24.14.0) (2024-08-12) ### Miscellaneous Chores * **embed-services:** Synchronize undefined versions ### Dependencies * The following workspace dependencies were updated * dependencies * @looker/sdk bumped from 24.12.1 to 24.14.0 * devDependencies * @looker/sdk-node bumped from 24.12.1 to 24.14.0 </details> <details><summary>extension-sdk: 24.14.0</summary> ## [24.14.0](extension-sdk-v24.12.1...extension-sdk-v24.14.0) (2024-08-12) ### Miscellaneous Chores * **extension-sdk:** Synchronize undefined versions ### Dependencies * The following workspace dependencies were updated * dependencies * @looker/sdk bumped from 24.12.1 to 24.14.0 </details> <details><summary>extension-sdk-react: 24.14.0</summary> ## [24.14.0](extension-sdk-react-v24.12.1...extension-sdk-react-v24.14.0) (2024-08-12) ### Miscellaneous Chores * **extension-sdk-react:** Synchronize undefined versions ### Dependencies * The following workspace dependencies were updated * dependencies * @looker/extension-sdk bumped from 24.12.1 to 24.14.0 * @looker/sdk bumped from 24.12.1 to 24.14.0 </details> <details><summary>sdk: 24.14.0</summary> ## [24.14.0](sdk-v24.12.1...sdk-v24.14.0) (2024-08-12) ### Features * generate SDKs for Looker 24.14 ([#1490](#1490)) ([1d72127](1d72127)) </details> <details><summary>sdk-node: 24.14.0</summary> ## [24.14.0](sdk-node-v24.12.1...sdk-node-v24.14.0) (2024-08-12) ### Miscellaneous Chores * **sdk-node:** Synchronize undefined versions ### Dependencies * The following workspace dependencies were updated * dependencies * @looker/sdk bumped from 24.12.1 to 24.14.0 </details> --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change alters the Go SDK client struct to accept an interface instead of the AuthSession. The interface allows for custom implementations of the RTL package, but since the existing AuthSession fulfills the new interface (its based on the Do method from the current AuthSession after all) this change will be completely transparent to those who are currently using the current AuthSession.