make credentail and host setup happen in build_client #939
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This so that features like logstash license checking can Take an instance of this plugin and extract the http client using the `build_client` method. As cloud id/credential/host setup was happening during register, extracting a client through build_client would result in a partially configured instance.
jsvd
force-pushed
the
move_cred_setup_to_build_client
branch
from
1b8fa10 to
28d8e5b
Compare
jsvd
changed the title
|
Merge into the 10.4 branch and released as v10.4.2 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #934 and elastic/logstash#11818
This patch release is intended essentially to solve the
cloud_idproblem reverted fix elastic/logstash#11800 for 7.6 and 7.7.