-
Notifications
You must be signed in to change notification settings - Fork 306
add elasticsearch API key support #934
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add elasticsearch API key support #934
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for adding the docs. What you have here builds cleanly and renders correctly.
From the issue description: "Only one authentication method must be specified out of (user/password, cloud_auth and api_key)". That info would be nice to call out in the docs. I suggest adding an "Authentication" section on par with "Retry Policy," "DLQ policy," and "ILM" to surface this information, and also making a note in each option about the alternatives that are excluded.
I can take this on in a subsequent PR if you would like. Let's discuss.
Thanks @karenzone - I just pushed some docs updates, LMKWYT. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the docs change, Colin. Docs still build and render correctly, so LGTM.
@kares following our conversation about the logstash license checker, I refactored to call the plugin validation methods from within LMKWYT |
@yaauie let me know if this looks good to you too plus if the requirement on explicit |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
bump version to 10.5.0
315992d
to
b65d45f
Compare
v10.5.0 published. Thanks @yaauie @kares @karenzone for the reviews! |
Hi, Its fixed but I still need to pass both API_ID and API_KEY value as "<API_ID>:<API_KEY> |
@AMITKHETAN can you please open an issue about this and explain your use-case and how & why you would prefer to pass the API_ID and API_KEY values? Thanks, |
Related to elastic/logstash#11788
Fixes #908
api_key
optionuser
/password
,cloud_auth
andapi_key
)TODO