Fixes the broken apache common http client link. #1101
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kaisecheng
reviewed
Dec 7, 2022
mashhurs
commented
Dec 8, 2022
| @@ -1185,7 +1185,7 @@ How long to wait before checking for a stale connection to determine if a keepal | |||
| Consider setting this value lower than the default, possibly to 0, if you get connection errors regularly. | |||
|
|
|||
| This client is based on Apache Commons. Here's how the | |||
| https://hc.apache.org/httpcomponents-client-ga/httpclient/apidocs/org/apache/http/impl/conn/PoolingHttpClientConnectionManager.html#setValidateAfterInactivity(int)[Apache | |||
There was a problem hiding this comment.
ga is now forwarding to httpclient5 which we unlikely use.
Co-authored-by: kaisecheng <[email protected]>
kaisecheng
approved these changes
Dec 8, 2022
* fix jruby bundler for test * Update .ci/logstash-run.sh Co-authored-by: Ry Biesemeyer <[email protected]> * Update .ci/logstash-run.sh Co-authored-by: Ry Biesemeyer <[email protected]> * Update .ci/logstash-run.sh Co-authored-by: Ry Biesemeyer <[email protected]>
mashhurs
commented
Dec 14, 2022
| @@ -1185,7 +1185,7 @@ How long to wait before checking for a stale connection to determine if a keepal | |||
| Consider setting this value lower than the default, possibly to 0, if you get connection errors regularly. | |||
|
|
|||
| This client is based on Apache Commons. Here's how the | |||
| https://hc.apache.org/httpcomponents-client-ga/httpclient/apidocs/org/apache/http/impl/conn/PoolingHttpClientConnectionManager.html#setValidateAfterInactivity(int)[Apache | |||
| https://hc.apache.org/httpcomponents-client-4.5.x/current/httpclient/apidocs/org/apache/http/impl/conn/PoolingHttpClientConnectionManager.html#setValidateAfterInactivity(int)[Apache | |||
There was a problem hiding this comment.
@yaauie what is your opinion for this change? Current link is broken and there is a GA link which is forwarding to httpclient5. We seem using 4.x versions.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the broken apache common http client link.
Closes Fix the broken
httpcomponents-clientlink. #1100 1100Broken: https://hc.apache.org/httpcomponents-client-ga/httpclient/apidocs/org/apache/http/impl/conn/PoolingHttpClientConnectionManager.html#setValidateAfterInactivity(int)
Suggesting: https://hc.apache.org/httpcomponents-client-4.5.x/current/httpclient/apidocs/org/apache/http/impl/conn/PoolingHttpClientConnectionManager.html#setValidateAfterInactivity(int)