fix jruby bundler for test #1099
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yaauie
reviewed
Dec 5, 2022
There was a problem hiding this comment.
Same reasoning as logstash-plugins/.ci#44 (review)
-rbundler/setupflag forjrubyexecutable is not needed when invoked insidebundle exec- run rspec directly (fragment
jruby -S rspec [RSPEC_ARGS...]->rspec [RSPEC_ARGS...]) - use long-form options in scripts for readability (rspec's
-fd->--format=documentation)
yaauie
reviewed
Dec 5, 2022
Co-authored-by: Ry Biesemeyer <[email protected]>
Co-authored-by: Ry Biesemeyer <[email protected]>
kaisecheng
commented
Dec 5, 2022
yaauie
approved these changes
Dec 8, 2022
mashhurs
pushed a commit
to mashhurs/logstash-output-elasticsearch
that referenced
this pull request
Dec 9, 2022
* fix jruby bundler for test * Update .ci/logstash-run.sh Co-authored-by: Ry Biesemeyer <[email protected]> * Update .ci/logstash-run.sh Co-authored-by: Ry Biesemeyer <[email protected]> * Update .ci/logstash-run.sh Co-authored-by: Ry Biesemeyer <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix: elastic/logstash#14800
Use the bundler in
/vendor/bundle/jruby/2.6.0/bin/bundleinstead of/vendor/jruby/bin/bundleto run test, as Logstash doesn't package the latter in artifacts in elastic/logstash#14667Thanks for contributing to Logstash! If you haven't already signed our CLA, here's a handy link: https://www.elastic.co/contributor-agreement/