Skip to content

Conversation

BenDavidAaron
Copy link

add warning about semicolon use to sql statement docs.

Thanks for contributing to Logstash! If you haven't already signed our CLA, here's a handy link: https://www.elastic.co/contributor-agreement/

add warning about semicolon use to sql statement docs.
@cla-checker-service
Copy link

cla-checker-service bot commented Apr 30, 2021

💚 CLA has been signed

@BenDavidAaron
Copy link
Author

I've completed the CLA now, can I resubmit those checks?

@karenzone karenzone added the documentation Improvements or additions to documentation label Jul 29, 2021
@karenzone karenzone requested review from andsel and karenzone July 29, 2021 22:54
@karenzone
Copy link
Contributor

@andsel Will you please validate from the technical perspective, and then reassign to me?
I will validate for docs, and get versions bumped and published.

@andsel
Copy link
Contributor

andsel commented Jul 30, 2021

Hi @BenDavidAaron I've looked at code, both NormalStatementHandler

and PreparedStatementHandler
@prepared = db[statement, *prepended].prepare(:select, name)
passes the statement property to Sequel driver as it is, it's retrieved directly from the Jdbc input plugin configuration.
Maybe it's Sequel library that does some manipulation, could you provide a way to reproduce/spot your sentence about the addition of ; that make the SQL invalid, please?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation status:needs-triage

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants