Only try and set permissions if permissions have changed. #295
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kares
reviewed
Jun 3, 2021
lib/filewatch/sincedb_collection.rb
Outdated
| @serializer.serialize(@sincedb, io, time.to_f) | ||
| end | ||
| rescue => e | ||
| logger.warn("sincedb_write: unable to write atomically, falling back to non-atomic write: #{path} error:", :exception => e.class, :message => e.message) |
There was a problem hiding this comment.
do you foresee atomic write potentially recovering, later?
if not maybe we would want the switch permanently to non-atomic ... (on the caller end).
guess this is rare, still seems like we would produce a lot of the same warn-ings (which might be fine 🤔).
There was a problem hiding this comment.
It's a good question. I think it might make sense to make the change 'sticky' in the event of permission errors, which are probably unlikely to recover later, and leave as is in the event of other errors.
kares
reviewed
Jun 9, 2021
kares
approved these changes
Jun 9, 2021
This is a workaround for jruby/jruby#6693 - stat is currently reporting incorrect values of `uid` and `gid` on aarch64 linux nodes, and appears to be setting `uid` and `gid` to 0, ie `root` It is highly unlikely that `chown` needs to be called on the file - and even more unlikely that `chown` would succeed anyway - `chmod` typically requires superuser privileges, unless the change of ownerhip is a change of group to another group the user is already a member of. This workaround updates the code to only attempt to call `chown` in the unlikely event that file ownership of the temp file is different from the original file, which should avoid the scenario that is currently occurring due to the above jruby bug. This commit also falls back to a non-atomic write in the event of a failure to write the file atomically.
…errors if `atomic_write` fails due to permission errors, update the write method to be `:non_atomic_write` to avoid unnecessary warn logs every time this occurs. This commit also adds trace logging to the `atomic_write` and `non_atomic_write`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a workaround for jruby/jruby#6693 - stat
is currently reporting incorrect values of
uidandgidon aarch64 linuxnodes, and appears to be setting
uidandgidto 0, ierootThis workaround will only attempt to call
chownif the unlikely event that thepermissions have changed. This will also "fallback" to a non-atomic write in the event
that an atomic write fails.