CI: reduce test flakiness on travis #263
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
identified and expected to be fixed in LS 7.6.2 ... for reference see elastic/logstash#11694
andsel
reviewed
Mar 23, 2020
|
Globally LGTM, just a comment I don't understand the meaning |
andsel
approved these changes
Mar 23, 2020
|
CI on master still failed: https://travis-ci.org/github/logstash-plugins/logstash-input-file/builds/665766313 putting this in a todo list to revisit later ... |
Closed
robbavey
added a commit
to robbavey/logstash-input-file
that referenced
this pull request
Mar 18, 2021
This plugin suffers from a large amount of test flakiness in the travis ci environment. This commit continues the attempts to reduce this flakiness, starting with logstash-plugins#263 Mostly, this is increasing timeouts to deal with sluggish build servers, but also includes a fix to a Stud.try call which would not retry due to failure exceptions not matching.
robbavey
added a commit
to robbavey/logstash-input-file
that referenced
this pull request
Apr 7, 2021
This plugin suffers from a large amount of test flakiness in the travis ci environment. This commit continues the attempts to reduce this flakiness, starting with logstash-plugins#263 Mostly, this is increasing timeouts to deal with sluggish build servers, but also includes a fix to a Stud.try call which would not retry due to failure exceptions not matching.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
and also a work-around for a known LS 7.6.1 bug