-
Notifications
You must be signed in to change notification settings - Fork 52
fix (platform): add importing existing vcluster to platform through helm values #1338
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
✅ Deploy Preview for vcluster-docs-site ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should focus more on the command flags, show sample vcluster.yaml and in an admonition mention that api key is needed. Also the apikey url does not resolve correctly on the preview environment.
I am not sure as I think that the way of using helm values to register the vcluster is described quite thoroughly in the external:
platform:
apiKey:
secretName: vcluster-platform-api-key # Defaults to vcluster-platform-api-key if undefined
namespace: vcluster-namespace # Namespace to search for the secret. If undefined, it searches the vCluster namespace. If different, vCluster needs access to the target namespace.
createRBAC: true # Defaults to true. Automatically creates the necessary RBAC roles and role bindings to locate the secret.then maybe I should also include how to get the secret and create the roles, which is already included in the |
Content Description
Add documentation of importing existing vcluster to platform through helm values
Preview Link
https://deploy-preview-1338--vcluster-docs-site.netlify.app/docs/platform/next/use-platform/virtual-clusters/add-virtual-clusters#post-deployment-platform-registration
Internal Reference
Closes DOC-311
@netlify /docs