Skip to content

Conversation

dfangl
Copy link
Member

@dfangl dfangl commented Feb 1, 2024

Motivation

We pulled upstream changes into our lambda init binary. (see localstack/lambda-runtime-init#30).

We should now update the binary, and set the account id in the environment, so it can properly returned when the Lambda-Extension-Accept-Feature header is set to accountId during the extension register call (https://docs.aws.amazon.com/lambda/latest/dg/runtimes-extensions-api.html#extensions-registration-api-a)

Changes

  • Update lambda init binary
  • Set account id of function into execution environment

@dfangl dfangl added the semver: patch Non-breaking changes which can be included in patch releases label Feb 1, 2024
Copy link

github-actions bot commented Feb 1, 2024

LocalStack Community integration with Pro

    2 files      2 suites   1h 24m 2s ⏱️
2 622 tests 2 372 ✅ 249 💤 1 ❌
2 624 runs  2 372 ✅ 251 💤 1 ❌

For more details on these failures, see this check.

Results for commit 40e4c3f.

♻️ This comment has been updated with latest results.

@dfangl dfangl force-pushed the update-lambda-init branch from ba06454 to 40e4c3f Compare February 6, 2024 11:09
@coveralls
Copy link

Coverage Status

coverage: 83.841% (+0.008%) from 83.833%
when pulling 40e4c3f on update-lambda-init
into a8ef05d on master.

@dfangl
Copy link
Member Author

dfangl commented Feb 6, 2024

https://github.com/localstack/localstack-ext/actions/runs/7799613007/job/21271112203 ext run fails with non-related tests only, so this should be good to go :)

Copy link
Member

@joe4dev joe4dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am happy to get these Lambda init update changes integrated 🚀 (at least a first iteration)

In the future, it would be great to support the Telemetry API to enable more Lambda extensions, and ultimately true X-ray tracing ✨

@dfangl dfangl merged commit 8e182da into master Feb 6, 2024
@dfangl dfangl deleted the update-lambda-init branch February 6, 2024 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
semver: patch Non-breaking changes which can be included in patch releases
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants